-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Introduce registry for caching and exposing TemplateNodeInfos #8911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Introduce registry for caching and exposing TemplateNodeInfos #8911
Conversation
|
Welcome @Choraden! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Choraden The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @Choraden. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…NodeInfos This change introduces a new component, TemplateNodeInfoRegistry, which wraps the existing TemplateNodeInfoProvider. It caches the computed template NodeInfos and exposes them via a thread-safe interface. This registry is added to the AutoscalingContext, allowing processors (like the DRA processor) to access the cached templates instead of relying on the less reliable NodeGroup.TemplateNodeInfo().
This change makes the DRACustomResourcesProcessor use TemplateNodeInfo from the previous autoscaling loop iteration preserving custom node options and devices. It falls back to NodeGroup.TemplateNodeInfo() if there are no good candidates.
f9c0302 to
ad96941
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
This change introduces a new component,
TemplateNodeInfoRegistry, which wraps the existingTemplateNodeInfoProvider. It caches the computed template NodeInfos and exposes them via a thread-safe interface.This registry is added to the AutoscalingContext, allowing processors (like the DRA processor) to access the cached templates instead of relying on the less reliable
NodeGroup.TemplateNodeInfo().Which issue(s) this PR fixes:
Fixes #8881
Fixes #8882
Special notes for your reviewer:
--
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: