Skip to content

ci: cleanup lint job #8765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 7, 2025
Merged

ci: cleanup lint job #8765

merged 4 commits into from
Nov 7, 2025

Conversation

@jackfrancis
Copy link
Contributor

@jackfrancis jackfrancis commented Nov 6, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR is the result of validating the current lint configuration against master branch. Some of the excluded directories are no longer needed, so those have been removed.

Also sending go list stderr to /dev/null we avoid unnecessary error outputs.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 6, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2025
@jackfrancis
Copy link
Contributor Author

jackfrancis commented Nov 6, 2025

/area cluster-autoscaler
/area vertical-pod-autoscaler

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2025
@jackfrancis
Copy link
Contributor Author

jackfrancis commented Nov 6, 2025

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 6, 2025
omerap12
omerap12 approved these changes Nov 7, 2025
View reviewed changes
Copy link
Member

@omerap12 omerap12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, omerap12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3b0c3bf into kubernetes:master Nov 7, 2025
6 checks passed
@jackfrancis jackfrancis deleted the lint-refresh branch November 7, 2025 17:35
@jackfrancis
Copy link
Contributor Author

jackfrancis commented Nov 7, 2025

/cherry-pick cluster-autoscaler-release-1.34

@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Nov 7, 2025

@jackfrancis: new pull request created: #8769

In response to this:

/cherry-pick cluster-autoscaler-release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 7, 2025
Merged
@jackfrancis
Copy link
Contributor Author

jackfrancis commented Nov 7, 2025

/cherry-pick cluster-autoscaler-release-1.33

@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Nov 7, 2025

@jackfrancis: new pull request created: #8770

In response to this:

/cherry-pick cluster-autoscaler-release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 7, 2025
Merged
This was referenced Nov 7, 2025
Merged
Merged
Merged
jonkerj pushed a commit to equinix-ms/k8s-autoscaler that referenced this pull request Nov 13, 2025
@jackfrancis @jonkerj
ci: cleanup lint job (kubernetes#8765)
70e1638 
* ci: cleanup lint job

* prove that linting still works

* this should make golint upset in VPA

* restore comments
jonkerj pushed a commit to equinix-ms/k8s-autoscaler that referenced this pull request Nov 24, 2025
@jackfrancis @jonkerj
ci: cleanup lint job (kubernetes#8765)
013ee34 
* ci: cleanup lint job

* prove that linting still works

* this should make golint upset in VPA

* restore comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@kgolab kgolab Awaiting requested review from kgolab

1 more reviewer

@omerap12 omerap12 omerap12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@omerap12 omerap12

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jackfrancis @k8s-ci-robot @k8s-infra-cherrypick-robot @omerap12