Upgraded Tekton Pipeline from v0.61.0 to v1.6.0 LTS #548
Conversation
…n-gh-enterprise Fix Tide automatic retrigger to use configured GitHub host
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
area/crier
k8s-ci-robot
added
the
area/podutils/entrypoint
|
Hi @prad9192. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-ok-to-test
| trap cleanup SIGINT SIGTERM EXIT | ||
| echo process started | ||
| sleep infinity & | ||
| sleep 9999 & |
There was a problem hiding this comment.
Changed this for macOS compatibility.
There was a problem hiding this comment.
Might be better to just do this in its own PR, but this is a pretty small change and just a couple lines, so probably no harm in including it here.
| Named(fmt.Sprintf("crier_%s", reporter.GetName())). | ||
| For(&prowv1.ProwJob{}). | ||
| WithOptions(controller.Options{MaxConcurrentReconciles: numWorkers, | ||
| RateLimiter: workqueue.DefaultControllerRateLimiter()}). |
There was a problem hiding this comment.
Deprecated hence using the new method - https://pkg.go.dev/k8s.io/[email protected]/util/workqueue#DefaultTypedControllerRateLimiter
|
Looks fine to me. The only question would be k8s skew version with the newer dependencies, but I think everything should be updated to be within an acceptable range of this anyway. /lgtm |
k8s-ci-robot
added
the
lgtm
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
k8s-ci-robot
removed
the
lgtm
|
Hello @stmcginnis |
|
/cc |
petr-muller
left a comment
petr-muller
left a comment
There was a problem hiding this comment.
I love that you added a new integration test, thanks!
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, prad9192 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 participants
What
Upgraded Tekton Pipeline from v0.61.0 to v1.6.0 LTS. Upgraded controller-runtime from v0.18.5 to v0.20.1 and k8s.io dependencies from v0.30.1 to v0.32.x. Added integration testing infrastructure for Tekton Pipeline controller.
Why
Tekton v1.6.0 LTS requires k8s.io v0.32.x dependencies, which forced controller-runtime upgrade to v0.20.1.