chore(chart): Refactor chart release logic to support releasing from master #1715
+72
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stevehipwell The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
stevehipwell
force-pushed
the
refactor-helm-chart-release
branch
from
c12fcb4 to
662c2c3
Compare
|
/retest |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
k8s-ci-robot
added
the
needs-rebase
stevehipwell
force-pushed
the
refactor-helm-chart-release
branch
from
662c2c3 to
581cb0f
Compare
k8s-ci-robot
removed
the
needs-rebase
|
@dgrisonnet could you please take a look at this? |
TerryHowe
reviewed
Sep 27, 2025
RELEASE.md
Outdated
| A new chart should be released whenever a new version of Metrics Server is | ||
| released, but releases can also be done on an as-needed basis. Most chart | ||
| releases for the latest Metrics Server version can take place on the `master` | ||
| branch; but if release is a backport or the chart on `master` is no longer |
There was a problem hiding this comment.
Suggested change
| branch; but if release is a backport or the chart on `master` is no longer | |
| branch. However, if a release is a backport or the chart on `master` is no longer |
RELEASE.md
Outdated
| released, but releases can also be done on an as-needed basis. Most chart | ||
| releases for the latest Metrics Server version can take place on the `master` | ||
| branch; but if release is a backport or the chart on `master` is no longer | ||
| compatible then the PR should target the release branch directly. |
There was a problem hiding this comment.
Suggested change
| compatible then the PR should target the release branch directly. | |
| compatible, the PR should target the release branch. |
.github/workflows/release-chart.yaml
Outdated
| if [[ "${branch_name}" == "master" ]]; then | ||
| release=true | ||
| else | ||
| branch_version_prefix="$(grep -Eo '[0-9]+\.[0-9]+$' <<<"${branch_name}")" |
There was a problem hiding this comment.
I'm a little confused on why this is called branch_version_prefix when it looks like it is the branch_version. The prefix to me would be release-
There was a problem hiding this comment.
It's the version prefix (x.y) and the branch suffix, let me make it a bit clearer.
k8s-ci-robot
added
the
needs-rebase
stevehipwell
force-pushed
the
refactor-helm-chart-release
branch
from
581cb0f to
376addc
Compare
k8s-ci-robot
removed
the
needs-rebase
…master Signed-off-by: Steve Hipwell <[email protected]>
stevehipwell
force-pushed
the
refactor-helm-chart-release
branch
from
376addc to
3ce1bd6
Compare
|
Thanks for the review @TerryHowe, I've applied your suggestions. |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for releasing the Helm chart from the
masterbranch while keeping support for releasing from a release branch if required (e.g. the chart has been modified to target the next release). This change will reduce the overhead for a chart release and allow us to be more responsive to chart changes.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
CC @dgrisonnet