Skip to content

feat: add rooted io/fs adapter - #6232

Open
iahsanGill wants to merge 1 commit into
kubernetes-sigs:masterfrom
iahsanGill:feat/rooted-filesystem-adapter
Open

feat: add rooted io/fs adapter#6232
iahsanGill wants to merge 1 commit into
kubernetes-sigs:masterfrom
iahsanGill:feat/rooted-filesystem-adapter

Conversation

@iahsanGill

Copy link
Copy Markdown
Contributor

Adds a RootedFS compatibility layer that exposes a rooted kyaml/filesys.FileSystem through the standard io/fs read interfaces. On-disk filesystems use os.Root; in-memory and other implementations use the same rooted relative-path contract through an adapter.

This keeps the existing public FileSystem API unchanged and provides a bounded migration path for #6220.

Tests cover io/fs conformance, in-memory and on-disk filesystems, sub-filesystems, invalid paths, and on-disk symlink containment.

Tests:

  • go test -race ./filesys
  • go vet ./filesys
  • go test ./...
  • repository lint, license, module-tidiness, and API compatibility checks

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iahsanGill
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @iahsanGill. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant