Skip to content

fix: support legacy release downloads - #6224

Open
CAOShurong wants to merge 2 commits into
kubernetes-sigs:masterfrom
CAOShurong:codex/support-legacy-kustomize-releases
Open

fix: support legacy release downloads#6224
CAOShurong wants to merge 2 commits into
kubernetes-sigs:masterfrom
CAOShurong:codex/support-legacy-kustomize-releases

Conversation

@CAOShurong

Copy link
Copy Markdown

Addresses #4130

What

  • route the finite set of pre-module releases to their original unprefixed tags
  • install their raw executable assets instead of treating them as tar archives
  • add v2.0.3 to the existing mocked-release workflow matrix

Why

install_kustomize.sh 2.0.3 currently queries kustomize/v2.0.3, even though that release is tagged v2.0.3. Its Linux asset is also a raw executable, while the current installer assumes every matching asset is a .tar.gz archive.

This follows the finite-tag approach suggested in the review of #4131 and keeps the existing module-era archive path unchanged.

Verification

  • regression fixture fails before the fix when the script tries to extract the raw v2.0.3 asset
  • mocked legacy, minimized, and unminimized release payloads install executable binaries
  • real v2.0.3, v3.3.0, and v5.8.1 releases install and report the requested versions on Linux
  • nonexistent version, missing destination, and existing destination paths still exit 1
  • bash -n hack/install_kustomize.sh
  • actionlint .github/workflows/test-install-kustomize.yml
  • go build . and go test ./... in kustomize/ with Go 1.26.5 on Linux

make lint was attempted with the repository-pinned golangci-lint v1.64.8, but package loading timed out in the first api module under the local WSL environment. It produced no finding in the changed files; the full repository lint remains to CI.

AI assistance disclosure

OpenAI Codex assisted with issue research, implementation, and test execution. The contributor remains responsible for the submitted changes. In accordance with the Kubernetes contribution policy, review comments will be answered personally without AI assistance.

Add the pre-module v2.0.3 release to the installer workflow matrix so the regression is exercised against its raw binary asset.
Select the unprefixed tags used before Kustomize's module release scheme and install their raw binary assets without treating them as tarballs.
@kubernetes-prow

Copy link
Copy Markdown
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@linux-foundation-easycla

Copy link
Copy Markdown

CLA Not Signed

@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @CAOShurong!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 13, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @CAOShurong. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 13, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CAOShurong
Once this PR has been reviewed and has the lgtm label, please assign koba1t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koba1t

koba1t commented Aug 13, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 13, 2026
@koba1t

koba1t commented Aug 13, 2026

Copy link
Copy Markdown
Member

@CAOShurong
Please pass the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants