fix: support legacy release downloads - #6224
Conversation
Add the pre-module v2.0.3 release to the installer workflow matrix so the regression is exercised against its raw binary asset.
Select the unprefixed tags used before Kustomize's module release scheme and install their raw binary assets without treating them as tarballs.
|
This PR has multiple commits, and the default merge method is: merge. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
Welcome @CAOShurong! |
|
Hi @CAOShurong. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CAOShurong The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test |
|
@CAOShurong |
Addresses #4130
What
Why
install_kustomize.sh 2.0.3currently querieskustomize/v2.0.3, even though that release is taggedv2.0.3. Its Linux asset is also a raw executable, while the current installer assumes every matching asset is a.tar.gzarchive.This follows the finite-tag approach suggested in the review of #4131 and keeps the existing module-era archive path unchanged.
Verification
bash -n hack/install_kustomize.shactionlint .github/workflows/test-install-kustomize.ymlgo build .andgo test ./...inkustomize/with Go 1.26.5 on Linuxmake lintwas attempted with the repository-pinned golangci-lint v1.64.8, but package loading timed out in the firstapimodule under the local WSL environment. It produced no finding in the changed files; the full repository lint remains to CI.AI assistance disclosure
OpenAI Codex assisted with issue research, implementation, and test execution. The contributor remains responsible for the submitted changes. In accordance with the Kubernetes contribution policy, review comments will be answered personally without AI assistance.