Skip to content

docs: migrate more examples off deprecated commonLabels - #6219

Open
locker95 wants to merge 1 commit into
kubernetes-sigs:masterfrom
locker95:docs/more-commonLabels-to-labels
Open

docs: migrate more examples off deprecated commonLabels#6219
locker95 wants to merge 1 commit into
kubernetes-sigs:masterfrom
locker95:docs/more-commonLabels-to-labels

Conversation

@locker95

@locker95 locker95 commented Aug 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Follow-up to the helloWorld/breakfast cleanup. springboot, configGeneration, and the alphaTestExamples helloapp demos still used commonLabels and trip the deprecation warning.

Switched those to labels with includeSelectors: true.

@locker95
docs: migrate more examples off deprecated commonLabels
779286d 
springboot, configGeneration, and alphaTestExamples helloapp still
used commonLabels. Switch them to labels with includeSelectors so
demos match current kustomize.

Signed-off-by: Dean Chen <862469039@qq.com>
@kubernetes-prow
kubernetes-prow Bot requested review from koba1t and sarab97 August 8, 2026 06:48
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 8, 2026
@kubernetes-prow

kubernetes-prow Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Hi @locker95. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 8, 2026
saitejabandaru-in
saitejabandaru-in approved these changes Aug 9, 2026
View reviewed changes

@saitejabandaru-in saitejabandaru-in left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice continuation of the commonLabels migration in the docs.

@kubernetes-prow

kubernetes-prow Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: locker95, saitejabandaru-in
Once this PR has been reviewed and has the lgtm label, please assign koba1t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koba1t koba1t Awaiting requested review from koba1t
@sarab97 sarab97 Awaiting requested review from sarab97
1 more reviewer
@saitejabandaru-in saitejabandaru-in saitejabandaru-in approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@locker95 @saitejabandaru-in