-
Notifications
You must be signed in to change notification settings - Fork 432
resolve 0.12 merge conflicts for helm values.yaml annotations and env #6948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-0.12
Are you sure you want to change the base?
resolve 0.12 merge conflicts for helm values.yaml annotations and env #6948
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Smuger The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Smuger. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Please don't change the cherry-pick to make it different than main. Otherwise the changes will be very hard to track. I accept this change may not be ideal, but then we should send a follow up change to the main, and cherrypick again. I'm still not clear if we have an issue or not. Let's discuss on that PR: #6682 (comment) |
/ok-to-test |
/hold |
What type of PR is this?
cleanup
What this PR does / why we need it:
Resolve merge conflicts for 0.12 for PR 6682 and remove frontend.kueueviz.local default for KUEUEVIZ_ALLOWED_ORIGINS
Which issue(s) this PR fixes:
Fixes #
PR 6682 - bad default value
Special notes for your reviewer:
@tenzen-y Please let me know if setting KUEUEVIZ_ALLOWED_ORIGINS to "" by default would be a smarter approach
@mimowo Here is my 0.12 merge conflict resolve PR. I'm a bit concerned with the wrong KUEUEVIZ_ALLOWED_ORIGINS default as mentioned by Tenzen here PR 6682 - bad default value
Does this PR introduce a user-facing change?