Skip to content

Conversation

Smuger
Copy link
Contributor

@Smuger Smuger commented Sep 22, 2025

What type of PR is this?

cleanup

What this PR does / why we need it:

Resolve merge conflicts for 0.12 for PR 6682 and remove frontend.kueueviz.local default for KUEUEVIZ_ALLOWED_ORIGINS

Which issue(s) this PR fixes:

Fixes #
PR 6682 - bad default value

Special notes for your reviewer:

@tenzen-y Please let me know if setting KUEUEVIZ_ALLOWED_ORIGINS to "" by default would be a smarter approach
@mimowo Here is my 0.12 merge conflict resolve PR. I'm a bit concerned with the wrong KUEUEVIZ_ALLOWED_ORIGINS default as mentioned by Tenzen here PR 6682 - bad default value

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added this to the v0.12 milestone Sep 22, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Smuger
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 22, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Smuger. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

netlify bot commented Sep 22, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 38a3875
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/68d16cb83f67f400082ea152
😎 Deploy Preview https://deploy-preview-6948--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 22, 2025
@mimowo
Copy link
Contributor

mimowo commented Sep 22, 2025

Resolve merge conflicts for 0.12 for #6682 and remove frontend.kueueviz.local default for KUEUEVIZ_ALLOWED_ORIGINS

Please don't change the cherry-pick to make it different than main. Otherwise the changes will be very hard to track.

I accept this change may not be ideal, but then we should send a follow up change to the main, and cherrypick again. I'm still not clear if we have an issue or not. Let's discuss on that PR: #6682 (comment)

@mimowo
Copy link
Contributor

mimowo commented Sep 22, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 22, 2025
@mimowo
Copy link
Contributor

mimowo commented Sep 24, 2025

/hold
Due to the inconsistency with the "main" branch. we need to either adjust the PR as in main, or change main.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants