🐛 (helm/v2-alpha): keep metrics flags and metrics resources in sync.

[camilamacedo86]

The ServiceMonitor now renders only when both prometheus.enabled and metrics.enabled are true. Charts generated from a manager that has no args field, an empty args list, or no --metrics-bind-address argument now get the metrics bind address added, so metrics.enabled, metrics.port, and metrics.secure always control the manager. Sidecar container arguments are left untouched.

Closes: #6021

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Copilot]

🟡 Changes recommended

ServiceMonitors remain independently enabled when metrics are disabled, contrary to the synchronization goal.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Synchronizes Helm metrics values with manager arguments and generated metrics resources.

Changes:

• Synthesizes metrics arguments for managers without them.
• Adds rendered-chart coverage for metrics toggles, ports, security, and sidecars.
• Documents fallback bind-address generation.

File summaries

File	Description
chart_generation_integration_test.go	Expands Helm rendering tests and helpers.
manager.go	Generates and templates manager metrics arguments.
helm-v2-alpha.md	Documents metrics port behavior.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 1
• Review effort level: Balanced

---

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

The implementation is sound, but the PR title violates the repository’s mandatory title format.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 7/15 changed files
• Comments generated: 0 new
• Review effort level: Balanced

[kubernetes-prow]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.