Skip to content

Conversation

@danehans
Copy link

What type of PR is this?
/kind feature

What this PR does / why we need it:

Allows users to convert Ingress resources with Ingress NGINX-specific annotations (currently only nginx.ingress.kubernetes.io/client-body-buffer-size) into Gateway API + Kgateway TrafficPolicy.

Which issue(s) this PR fixes:

Fixes #260

Does this PR introduce a user-facing change?:

Adds provider "kgateway". This provider acts as an output implementation provider as apposed to the traditional provider that is used as a source.

yuval-k and others added 2 commits November 18, 2025 09:40
Signed-off-by: Daneyon Hansen <[email protected]>
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danehans
Once this PR has been reviewed and has the lgtm label, please assign liorlieberman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 18, 2025
@danehans
Copy link
Author

I wanted to share this approach before getting too deep into the implementation. Looking for feedback from maintainers.

@k8s-ci-robot
Copy link
Contributor

@danehans: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ingress2gateway-verify 5069ab4 link true /test pull-ingress2gateway-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Stevenjin8
Copy link
Contributor

Yeah I read briefly through the PR and I think we should take a step back. As I understand this PR, when using the kgateway effectively translates ingress + a specific ingress-nginx annotation to kgw. I would much rather see a generic approach.

@LiorLieberman
Copy link
Member

LiorLieberman commented Nov 18, 2025

Thanks @danehans !

We had a break room session over kubecon - and the general ask was to agree on some foundational direction for this repo. @Stevenjin8 took this initiative and have some initial draft here

The main point to discuss is whether ingress2gateway is the place to host all this vendored code or we should have some other extensibility in place. I do know the urgency here, so hoping we can get agreements and collaboration here fast.

The main concern is maintainability.

Some prior art all points the direction of removal third party code from kubernetes.

@rikatz pointed out one example.

On Kubernetes we avoid vendor specific code and tend to have it as third party repos - See the removal of CSI drivers from core Kubernetes code, for instance

@danehans
Copy link
Author

Closing in favor of #262 (implementation-specific emitters).

@danehans danehans closed this Nov 19, 2025
@danehans
Copy link
Author

The main point to discuss is whether ingress2gateway is the place to host all this vendored code or we should have some other extensibility in place. I do know the urgency here, so hoping we can get agreements and collaboration here fast.
The main concern is maintainability.

I completely agree that a solution must be maintainable. I'm hoping #262 is an approach that the community feels will meet this goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Kgateway as an Ouput Provider

5 participants