-
Notifications
You must be signed in to change notification settings - Fork 97
Initial Kgateway Provider Support #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Daneyon Hansen <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: danehans The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I wanted to share this approach before getting too deep into the implementation. Looking for feedback from maintainers. |
|
@danehans: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Yeah I read briefly through the PR and I think we should take a step back. As I understand this PR, when using the |
|
Thanks @danehans ! We had a break room session over kubecon - and the general ask was to agree on some foundational direction for this repo. @Stevenjin8 took this initiative and have some initial draft here The main point to discuss is whether ingress2gateway is the place to host all this vendored code or we should have some other extensibility in place. I do know the urgency here, so hoping we can get agreements and collaboration here fast. The main concern is maintainability. Some prior art all points the direction of removal third party code from kubernetes. @rikatz pointed out one example.
|
|
Closing in favor of #262 (implementation-specific emitters). |
I completely agree that a solution must be maintainable. I'm hoping #262 is an approach that the community feels will meet this goal. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allows users to convert Ingress resources with Ingress NGINX-specific annotations (currently only
nginx.ingress.kubernetes.io/client-body-buffer-size) into Gateway API + Kgateway TrafficPolicy.Which issue(s) this PR fixes:
Fixes #260
Does this PR introduce a user-facing change?: