Add opentelemetry tracing instrumentation #1125
Conversation
Signed-off-by: sallyom <[email protected]>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sallyom The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-rebase
| res, err := resource.New(ctx, | ||
| resource.WithAttributes( | ||
| semconv.ServiceNameKey.String(config.ServiceName), | ||
| semconv.ServiceVersionKey.String("1.0.0"), |
There was a problem hiding this comment.
Does it make sense to use debug/buildinfo here?
|
|
||
| func StartGatewaySpan(ctx context.Context, operation string) (context.Context, trace.Span) { | ||
| ctx, span := StartSpan(ctx, operation, operation) | ||
| // TODO: Add common gateway attributes here | ||
| return ctx, span | ||
| } |
There was a problem hiding this comment.
Maybe we want to replace them with something like:
func SetGatewayAttributes(span trace.Span, gateway Gateway) {
if gateway == nil {
return
}
span.SetAttributes(
AttrGatewaySomething.String(gateway.Something()),
)
}Allowing a user to set attributes without the need to know the specific Keys?
| conn, err := grpc.DialContext(ctx, config.ExporterEndpoint, | ||
| grpc.WithTransportCredentials(insecure.NewCredentials()), | ||
| grpc.WithBlock(), | ||
| grpc.WithTimeout(5*time.Second), |
| } | ||
|
|
||
| if samplingRate := os.Getenv(envOTELSamplingRate); samplingRate != "" { | ||
| if rate, err := strconv.ParseFloat(samplingRate, 64); err == nil { |
There was a problem hiding this comment.
Does it make sense to inform the user e.g. by failing during the creation whenever a value is not recognized?
|
hi @sallyom, this draft PR seems out of sync. |
No description provided.