Skip to content

docs: add prometheus + grafana deployment guide #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EyalPazz
Copy link
Member

/fixes #747

Copy link

netlify bot commented Jun 19, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit eb6ab1e
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/686e8d757c680c000879ff51
😎 Deploy Preview https://deploy-preview-1019--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EyalPazz
Once this PR has been reviewed and has the lgtm label, please assign arangogutierrez for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 19, 2025
@EyalPazz
Copy link
Member Author

@nirrozenbaum @danehans

Comment on lines 147 to 149
helm install prometheus prometheus-community/prometheus \
--namespace monitoring --create-namespace \
-f https://github.com/kubernetes-sigs/gateway-api-inference-extension/raw/main/config/manifests/prometheus/values.yaml
Copy link
Contributor

@nirrozenbaum nirrozenbaum Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after running this step, I'm running the command from the helm output to get prometheus pod:

Get the Prometheus server URL by running these commands in the same shell:
  export POD_NAME=$(kubectl get pods --namespace monitoring -l "app.kubernetes.io/name=prometheus,app.kubernetes.io/instance=prometheus" -o jsonpath="{.items[0].metadata.name}")
  kubectl --namespace monitoring port-forward $POD_NAME 9090

when running the export POD_NAME=... I get the following error:

error: error executing jsonpath "{.items[0].metadata.name}": Error executing template: array index out of bounds: index 0, length 0. Printing more information for debugging the template:
	template was:
		{.items[0].metadata.name}
	object given to jsonpath engine was:
		map[string]interface {}{"apiVersion":"v1", "items":[]interface {}{}, "kind":"List", "metadata":map[string]interface {}{"resourceVersion":""}}

no pod matches the command. maybe something is missing from values.yaml?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is relying on the merge to main, it's currently pointing to the main branch despite it's not there yet

You can currently test using:
https://raw.githubusercontent.com/eyalpazz/gateway-api-inference-extension/add-prometheus-guide/config/manifests/prometheus/values.yaml

Copy link
Contributor

@nirrozenbaum nirrozenbaum Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the error after I copied values.yaml locally and used it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind trying the instructions on a fresh kind cluster?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, i'll try to do it later tonight

@EyalPazz EyalPazz requested a review from nirrozenbaum June 24, 2025 15:15
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2025
@danehans
Copy link
Contributor

@EyalPazz pls rebase.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 9, 2025
@EyalPazz EyalPazz force-pushed the add-prometheus-guide branch from d9739ce to 2dc2f1a Compare July 9, 2025 15:10
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 9, 2025
@EyalPazz EyalPazz force-pushed the add-prometheus-guide branch from 2dc2f1a to c4fd7e6 Compare July 9, 2025 15:13
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 9, 2025
@EyalPazz EyalPazz force-pushed the add-prometheus-guide branch from c4fd7e6 to 7508fbe Compare July 9, 2025 15:21
@EyalPazz EyalPazz force-pushed the add-prometheus-guide branch from 7508fbe to eb6ab1e Compare July 9, 2025 15:40
@EyalPazz
Copy link
Member Author

EyalPazz commented Jul 9, 2025

Rebased, sry for the delay

@EyalPazz
Copy link
Member Author

EyalPazz commented Jul 9, 2025

@nirrozenbaum did it work for you after we talked in private?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics dashboard should be documented for options other than Google Managed Prometheus
4 participants