-
Notifications
You must be signed in to change notification settings - Fork 447
✨ feat: add verbose logging option to controller-gen #1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
✨ feat: add verbose logging option to controller-gen #1273
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wazery The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @wazery. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
af08133
to
f076494
Compare
@JoelSpeed many thanks for the valuable insights, I reflected them all in the PR now. |
f076494
to
960e43d
Compare
Adds verbose logging to controller-gen which is disabled by default, and can be enabled. It uses
slog
as suggested in the issue #889Example:
./controller-gen crd verbose=true paths=./pkg/crd/testdata output:stdout
Fixes: #889