Skip to content

🌱 Promote JoelSpeed to approver #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

JoelSpeed
Copy link
Contributor

I was added to this repository as a reviewer at the end of January, and over the past several years and even more so this year, have been providing consistent input on both issues and pull requests, primarily providing guidance on API guidelines and how upstream API machinery fits together.

I would like to propose that I'm promoted to approver in recognition of this consistent input.

CC @sbueringer @alvaroaleman

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 19, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 19, 2025
@sbueringer
Copy link
Member

sbueringer commented Jun 19, 2025

I thought we did this already 😂 (but yeah we only talked about it in May)

Thank you very much for all your contributions!! Really appreciate it!

/lgtm

/assign @alvaroaleman

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3b0e3f8b0a13a245953aea5dc35b824195a5a2ce

@camilamacedo86
Copy link
Member

camilamacedo86 commented Jun 19, 2025

@JoelSpeed has been contributing a lot
/lgtm
(besides, I am not a maintainer, just a contributor :-) +1; if I can so :-P )

Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome, happy to have you!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9afcc17 into kubernetes-sigs:main Jun 19, 2025
9 checks passed
@sbueringer
Copy link
Member

@JoelSpeed
Copy link
Contributor Author

I have a couple of those to do, will get a PR up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants