-
Notifications
You must be signed in to change notification settings - Fork 440
🌱 Promote JoelSpeed to approver #1220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Promote JoelSpeed to approver #1220
Conversation
I thought we did this already 😂 (but yeah we only talked about it in May) Thank you very much for all your contributions!! Really appreciate it! /lgtm /assign @alvaroaleman |
LGTM label has been added. Git tree hash: 3b0e3f8b0a13a245953aea5dc35b824195a5a2ce
|
@JoelSpeed has been contributing a lot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome, happy to have you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JoelSpeed Welcome! Feel free to open a PR to add yourself to https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/controller-tools/OWNERS |
I have a couple of those to do, will get a PR up |
I was added to this repository as a reviewer at the end of January, and over the past several years and even more so this year, have been providing consistent input on both issues and pull requests, primarily providing guidance on API guidelines and how upstream API machinery fits together.
I would like to propose that I'm promoted to approver in recognition of this consistent input.
CC @sbueringer @alvaroaleman