Skip to content

Conversation

@kahirokunn
Copy link
Member

@kahirokunn kahirokunn commented Nov 4, 2025

Summary

This PR introduces a working example that uses the controller-runtime client to interact with ClusterProfile CRDs, and renames credentialProviders to accessProviders for clearer terminology and consistency.

Motivation

  • Provide a canonical, minimal example for consumers who prefer controller-runtime over raw client-go.
  • Align naming with the “access providers”

Release notes

- Add controller-runtime client example under examples/controller-example
- Rename credentialProviders to accessProviders

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 4, 2025
@kahirokunn kahirokunn force-pushed the add-controller-runtime-example branch from 776d76b to c7c247a Compare November 4, 2025 00:39
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2025
@kahirokunn kahirokunn force-pushed the add-controller-runtime-example branch from e36279a to e052e46 Compare November 4, 2025 00:47
@kahirokunn kahirokunn changed the title Add controller-runtime client example Add controller-runtime client example and rename credentialProviders to accessProviders Nov 4, 2025
@kahirokunn kahirokunn force-pushed the add-controller-runtime-example branch from e052e46 to f64e992 Compare November 4, 2025 00:55
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kahirokunn, ryanzhang-oss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2025
@ryanzhang-oss
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit ed4b45f into kubernetes-sigs:main Nov 11, 2025
3 checks passed
@kahirokunn
Copy link
Member Author

Thanks for your review 🙏

corentone pushed a commit to corentone/cluster-inventory-api that referenced this pull request Nov 13, 2025
📖 Minor adjustments to README, mention dynamic fleet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants