🐛 MachineSet/KCP: Preserve existing object names for backward compatibility with pre-v1.7 in-place updates

[liuxu623]

What this PR does / why we need it:

Prior to Cluster API v1.7, infraMachine and bootstrapConfig objects created by MachineSet and KubeadmControlPlane could have names that differed from their associated Machine names. Starting from v1.7 (#9833), these objects consistently use the Machines name.

When performing in-place updates on Machines created before v1.7, we must preserve the existing infraMachine and bootstrapConfig names to avoid breaking associations with existing infrastructure resources.

This commit ensures backward compatibility by preserving existing bootstrapConfig names in computeDesiredBootstrapConfig and existing infraMachine names in computeDesiredInfraMachine.

Part of #12291

/area machineset
/area provider/control-plane-kubeadm

[k8s-ci-robot]

Hi @liuxu623. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[liuxu623]

/assign fabriziopandini

[fabriziopandini]

@liuxu623 thanks for this PR
I will try to get it merged for the .1 patch release in ~1 week (it is too late for today's release)

[fabriziopandini]

/retest

[fabriziopandini]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: c926d67aab3c1a6c21e7bf70356a59cd2b5590d3

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fabriziopandini]

/cherry-pick release-1.12

[k8s-infra-cherrypick-robot]

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[fabriziopandini]

/retest

[fabriziopandini]

/test pull-cluster-api-test-main

[fabriziopandini]

/retest

[fabriziopandini]

/test pull-cluster-api-e2e-blocking-main

[fabriziopandini]

/retest

[fabriziopandini]

/test pull-cluster-api-e2e-blocking-main

[liuxu623]

/test pull-cluster-api-e2e-blocking-main

[k8s-ci-robot]

@liuxu623: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-cluster-api-e2e-blocking-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[fabriziopandini]

/test pull-cluster-api-e2e-blocking-main

[k8s-infra-cherrypick-robot]

@fabriziopandini: new pull request created: #13147

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.