-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 [release-1.10] Bump Go to v1.24.11 #13117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 [release-1.10] Bump Go to v1.24.11 #13117
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold |
|
@mboersma we still haven't fixed the golang ci issue on 1.10 (the fix we used on other branches doesn't work here) |
| # | ||
| GO_VERSION ?= 1.24.10 | ||
| GO_VERSION ?= 1.24.11 | ||
| GO_DIRECTIVE_VERSION ?= 1.23.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabriziopandini we've been keeping GO_DIRECTIVE_VERSION at 1.23 in this branch, despite moving the actual toolchain version forward to 1.24.x. That's unlike main and the other branches--could this have something to do with the lint issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lint issue is due to a golangci-lint bug fixed in 2.7.0, but this brach is using a very old version of golangci-lint and bumping is not feasible, so we are looking into possible workarounds
|
/close replaced by #13132 to get around of the lint issue existing at the time this PR was created (also rushing to try to get some green signal before today's release) |
|
@fabriziopandini: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is a manual cherry-pick of #13106
/area dependency