Skip to content

Conversation

@mboersma
Copy link
Contributor

@mboersma mboersma commented Dec 8, 2025

This is a manual cherry-pick of #13106

/area dependency

@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Dec 8, 2025
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Dec 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 8, 2025
@fabriziopandini
Copy link
Member

fabriziopandini commented Dec 8, 2025

/hold
I would defer to merge after the release tomorrow (we are slowly recovering from the effects of an issue in the CI in the week end)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2025
@fabriziopandini
Copy link
Member

@mboersma we still haven't fixed the golang ci issue on 1.10 (the fix we used on other branches doesn't work here)

#
GO_VERSION ?= 1.24.10
GO_VERSION ?= 1.24.11
GO_DIRECTIVE_VERSION ?= 1.23.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabriziopandini we've been keeping GO_DIRECTIVE_VERSION at 1.23 in this branch, despite moving the actual toolchain version forward to 1.24.x. That's unlike main and the other branches--could this have something to do with the lint issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint issue is due to a golangci-lint bug fixed in 2.7.0, but this brach is using a very old version of golangci-lint and bumping is not feasible, so we are looking into possible workarounds

@fabriziopandini
Copy link
Member

/close

replaced by #13132 to get around of the lint issue existing at the time this PR was created (also rushing to try to get some green signal before today's release)

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Closed this PR.

Details

In response to this:

/close

replaced by #13132 to get around of the lint issue existing at the time this PR was created (also rushing to try to get some green signal before today's release)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mboersma mboersma deleted the bump-go-toolchain-release-1.10 branch December 9, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants