Skip to content

Conversation

@fabriziopandini
Copy link
Member

What this PR does / why we need it:

/area documentation

@k8s-ci-robot k8s-ci-robot added the area/documentation Issues or PRs related to documentation label Dec 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 1, 2025
@fabriziopandini fabriziopandini force-pushed the documentation-for-chained-upgrades branch from 01249a9 to 03df0a3 Compare December 1, 2025 10:55
@fabriziopandini
Copy link
Member Author

/cherry-pick release-1.12

@k8s-infra-cherrypick-robot

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fabriziopandini fabriziopandini force-pushed the documentation-for-chained-upgrades branch from 03df0a3 to afd0d8a Compare December 1, 2025 14:56

### Chained upgrade
An upgrade sequence that goes from one Kubernetes version to another by passing through a set of intermediate versions.
e.g., Upgrading from v1.31.0 (current state) to v1.34.0 (target version) requires
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
e.g., Upgrading from v1.31.0 (current state) to v1.34.0 (target version) requires
E.g. upgrading from v1.31.0 (current state) to v1.34.0 (target version) requires

### Chained upgrade
An upgrade sequence that goes from one Kubernetes version to another by passing through a set of intermediate versions.
e.g., Upgrading from v1.31.0 (current state) to v1.34.0 (target version) requires
a chained upgrade with the following steps: v1.32.0 (first intermediate version)-> v1.33.0 (second intermediate version) -> v1.34.0 (target version).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
a chained upgrade with the following steps: v1.32.0 (first intermediate version)-> v1.33.0 (second intermediate version) -> v1.34.0 (target version).
a chained upgrade with the following steps: v1.32.0 (first intermediate version) -> v1.33.0 (second intermediate version) -> v1.34.0 (target version).

Comment on lines 365 to 366
With this regard, the recommendation is to keep the upgrade workflow a simple as fast as possible, e.g.
should avoid to combine application upgrades and Kubernetes version upgrade in a single workflow to risks under control.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
With this regard, the recommendation is to keep the upgrade workflow a simple as fast as possible, e.g.
should avoid to combine application upgrades and Kubernetes version upgrade in a single workflow to risks under control.
With this regard, the recommendation is to keep the upgrade workflow as simple and as fast as possible, e.g. combining application upgrades and Kubernetes version upgrade in a single workflow should be avoided.

- If instead for any reason a custom upgrade plan for workers is required, `workersUpgrades` should be set and
the following rules apply to each version in the list. More specifically, each version must be:
- equal to `FromControlPlaneKubernetesVersion` or to one of the versions in the control plane upgrade plan.
- greater than `FromWorkersKubernetesVersion` (or with a different build number)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some places we are using serialised name and few places the name as is , For example
fromControlPlaneKubernetesVersion vs FromControlPlaneKubernetesVersion, Should we stick to one format?

@fabriziopandini fabriziopandini added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants