-
Notifications
You must be signed in to change notification settings - Fork 1.4k
📖 Improve v1.12 migration docs #13079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
📖 Improve v1.12 migration docs #13079
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a placeholder, #12971 is going to add the content of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the corresponding PR is merged and it needs a rebase?
|
/test pull-cluster-api-verify-main |
|
/test pull-cluster-api-test-main |
55882f4 to
df98b9c
Compare
|
/cherry-pick release-1.12 |
|
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
df98b9c to
5ac7f28
Compare
| - A new, optional rule has been added to the control plane contract, defining what is required for implementing support | ||
| for in-place updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes for the control plane contract are included in #13088
chrischdi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit + pending rebase
| - The new `spec.taint` field has been added. | ||
| - The `HealthCheckSucceeded` condition reports a new `UnhealthyMachine` reason when `unhealthyMachineConditions` checks fail | ||
| - The `UpToDate` condition reports a new `Updating` reason when a machine is performing in-place updates | ||
| - The new `Updating` condition has been added. It reports status `true` when a machine is performing in-place updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - The new `Updating` condition has been added. It reports status `true` when a machine is performing in-place updates. | |
| - The new `Updating` condition has been added. It reports status `True` when a machine is performing in-place updates. |
status in condition is uppercase :-)
|
|
||
| - Lifecycle hooks | ||
| - The request message for the `BeforeClusterUpgrade` hook has been extended to include info about the upgrade plan. | ||
| - The new `BeforeControlPlaneUpgrade` hook has been added; the hook is called before each "upgrade control plane" step; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is semicolon (;) intentional?
|
|
||
| ## Deprecation | ||
|
|
||
| - The following reasons for the `TopologyReconciled` condition on the `Cluster`object are now deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - The following reasons for the `TopologyReconciled` condition on the `Cluster`object are now deprecated | |
| - The following reasons for the `TopologyReconciled` condition on the `Cluster` object are now deprecated |
| will implement temporarily compatibility with the deprecated v1beta1 version of the Cluster API contract | ||
| - Compatibility is only intended to ease the transition for providers, and it has some limitations; please | ||
| read details in following paragraphs. | ||
| - Compatibility support for the v1beta1 version of the Cluster API contract will be removed tentatively in August 2026 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Compatibility support for the v1beta1 version of the Cluster API contract will be removed tentatively in August 2026 | |
| - Compatibility support for the v1beta1 version of the Cluster API contract will be removed tentatively in August 2026. |
5ac7f28 to
c4bf7e4
Compare
c4bf7e4 to
dadcf7d
Compare
dadcf7d to
8fa1a67
Compare
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area documentation