Skip to content

Conversation

@fabriziopandini
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area documentation

@k8s-ci-robot k8s-ci-robot added the area/documentation Issues or PRs related to documentation label Nov 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 28, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 28, 2025
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a placeholder, #12971 is going to add the content of this PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the corresponding PR is merged and it needs a rebase?

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-verify-main

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-main

@fabriziopandini fabriziopandini force-pushed the improve-1.12-migration-docs branch from 55882f4 to df98b9c Compare December 1, 2025 11:33
@fabriziopandini
Copy link
Member Author

/cherry-pick release-1.12

@k8s-infra-cherrypick-robot

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fabriziopandini fabriziopandini force-pushed the improve-1.12-migration-docs branch from df98b9c to 5ac7f28 Compare December 2, 2025 13:17
Comment on lines +144 to +145
- A new, optional rule has been added to the control plane contract, defining what is required for implementing support
for in-place updates.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for the control plane contract are included in #13088

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2025
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit + pending rebase

- The new `spec.taint` field has been added.
- The `HealthCheckSucceeded` condition reports a new `UnhealthyMachine` reason when `unhealthyMachineConditions` checks fail
- The `UpToDate` condition reports a new `Updating` reason when a machine is performing in-place updates
- The new `Updating` condition has been added. It reports status `true` when a machine is performing in-place updates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The new `Updating` condition has been added. It reports status `true` when a machine is performing in-place updates.
- The new `Updating` condition has been added. It reports status `True` when a machine is performing in-place updates.

status in condition is uppercase :-)


- Lifecycle hooks
- The request message for the `BeforeClusterUpgrade` hook has been extended to include info about the upgrade plan.
- The new `BeforeControlPlaneUpgrade` hook has been added; the hook is called before each "upgrade control plane" step;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is semicolon (;) intentional?


## Deprecation

- The following reasons for the `TopologyReconciled` condition on the `Cluster`object are now deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The following reasons for the `TopologyReconciled` condition on the `Cluster`object are now deprecated
- The following reasons for the `TopologyReconciled` condition on the `Cluster` object are now deprecated

will implement temporarily compatibility with the deprecated v1beta1 version of the Cluster API contract
- Compatibility is only intended to ease the transition for providers, and it has some limitations; please
read details in following paragraphs.
- Compatibility support for the v1beta1 version of the Cluster API contract will be removed tentatively in August 2026
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Compatibility support for the v1beta1 version of the Cluster API contract will be removed tentatively in August 2026
- Compatibility support for the v1beta1 version of the Cluster API contract will be removed tentatively in August 2026.

@fabriziopandini fabriziopandini force-pushed the improve-1.12-migration-docs branch from 5ac7f28 to c4bf7e4 Compare December 3, 2025 12:43
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2025
@fabriziopandini fabriziopandini force-pushed the improve-1.12-migration-docs branch from c4bf7e4 to dadcf7d Compare December 3, 2025 12:44
@fabriziopandini fabriziopandini added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 3, 2025
@fabriziopandini fabriziopandini force-pushed the improve-1.12-migration-docs branch from dadcf7d to 8fa1a67 Compare December 4, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants