🌱 Avoid KCP rollouts if only ControlPlaneComponentHealthCheckSeconds is changed #13026
+110
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
do-not-merge/needs-area
sbueringer
force-pushed
the
pr-repro-rollout
branch
from
6b29f13 to
97e6fc3
Compare
sbueringer
commented
Nov 21, 2025
test/e2e/clusterctl_upgrade_test.go
Outdated
|
|
||
| // Note: This test should be changed during "prepare main branch", it should test n-2 => current. | ||
| var _ = Describe("When testing clusterctl upgrades using ClusterClass (v1.10=>current) [ClusterClass]", Label("ClusterClass"), func() { | ||
| var _ = Describe("When testing clusterctl upgrades using ClusterClass (v1.10=>current) [ClusterClass] [PR-Blocking]", Label("ClusterClass"), func() { |
Member
Author
There was a problem hiding this comment.
This part should not be merged
/hold
k8s-ci-robot
added
the
do-not-merge/hold
sbueringer
force-pushed
the
pr-repro-rollout
branch
from
97e6fc3 to
ca041a4
Compare
Member
Author
k8s-ci-robot
added
size/M
sbueringer
force-pushed
the
pr-repro-rollout
branch
from
3626690 to
2f4c5c6
Compare
Member
Author
|
/test pull-cluster-api-e2e-main-gke |
sbueringer
changed the title
Member
Author
|
/test pull-cluster-api-e2e-main-gke |
Member
|
/retest Different flake |
sbueringer
force-pushed
the
pr-repro-rollout
branch
from
e0e29dc to
077225e
Compare
k8s-ci-robot
removed
the
size/M
sbueringer
changed the title
k8s-ci-robot
added
size/L
sbueringer
changed the title
Member
Author
|
/test pull-cluster-api-e2e-main-gke |
sbueringer
force-pushed
the
pr-repro-rollout
branch
from
077225e to
afff7e2
Compare
Member
Author
|
/test pull-cluster-api-e2e-main-gke |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 097e9fc6a5ac8cd1e675e3b92d28ce7fa5386288
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Member
|
/lgtm Thanks! |
sbueringer
added
area/provider/control-plane-kubeadm
Member
Author
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Member
Author
|
Independent flakes /override pull-cluster-api-e2e-main-gke |
Contributor
|
@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main-gke In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #13017