Skip to content

Conversation

@alexander-demicev
Copy link
Contributor

What this PR does / why we need it:

This PR adds notes about KCP implementation and managed field refactoring. @sbueringer @fabriziopandini could you please verify that I didn't miss anything and got it all right, also I wasn't sure if we should move these notes into the proposal or keep them separated.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 20, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2025
@alexander-demicev
Copy link
Contributor Author

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation and removed do-not-merge/needs-area PR is missing an area label labels Nov 20, 2025
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR.
i've added some comments on grammar. note that this is not a implementation correctness pass.

Q: i know that the CAPI book has a lot of details, but this seems like it's going trough the controller source code and covering everything. is the average reader that interested in documentation verbosity ALA "i what to know exactly how this works"? for comparison, the k8s documentation doesn't do that.

@fabriziopandini
Copy link
Member

great work!
lgtm pending comment above

@alexander-demicev
Copy link
Contributor Author

@neolit123 Hey, I addressed your comments. A follow-up PR will be made to update the proposal and user-facing docs. These docs are for engineers working directly on the CAPI code to have a place to refer to in case knowledge transfer is needed.

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 664a4048a68ed2679f0181b35d2e8507dd495823

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2025
@fabriziopandini
Copy link
Member

/cherry-pick release-1.12

@k8s-infra-cherrypick-robot

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 1757d5f into kubernetes-sigs:main Dec 8, 2025
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Dec 8, 2025
@k8s-infra-cherrypick-robot

@fabriziopandini: new pull request created: #13118

Details

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants