🌱 Migrate from Requeue to RequeueAfter in extensionconfig #13000
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
do-not-merge/needs-area
|
/retest |
| g.Expect(err).ToNot(HaveOccurred()) | ||
| // If the registry isn't warm the reconcile loop will return Requeue: True | ||
| g.Expect(res.Requeue).To(BeTrue()) | ||
| g.Expect(res.RequeueAfter).To(BeTrue()) |
There was a problem hiding this comment.
Let's adjust the prod code to use RequeueAfter 10 * time.Seconds and check for that value here.
Any idea why the linter is not finding the prod code usage?
There are also some other usages in the KCP controller
There was a problem hiding this comment.
I've missed these things because staticcheck didn't report it, and then this issue has been opened in this.
So currently, it's hard to report it via lint. We should find problems by manually 😮💨
There was a problem hiding this comment.
Ah wow, that's good to know.
I think we'll figure it out. I found the other usages with "Find Usages" on the Requeue field in Intellij
sivchari
force-pushed
the
migrate-extensionconfig-requeue-to-requeueafter
branch
from
6680154 to
3d53188
Compare
sivchari
force-pushed
the
migrate-extensionconfig-requeue-to-requeueafter
branch
from
3d53188 to
29c9bb1
Compare
Signed-off-by: sivchari <[email protected]>
sivchari
force-pushed
the
migrate-extensionconfig-requeue-to-requeueafter
branch
from
29c9bb1 to
34b9a46
Compare
|
Thx! /lgtm /area runtime-sdk |
k8s-ci-robot
added
area/runtime-sdk
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: a84a8898b313b2a6be6943b7b3be9d4047941e3e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
3 participants
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #12272