Skip to content

🌱 Add hint to look into controller logs to runtime client error response #12849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

🌱 Add hint to look into controller logs to runtime client error response #12849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/runtime/client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func (c *client) Discover(ctx context.Context, extensionConfig *runtimev1.Extens
if response.GetStatus() == runtimehooksv1.ResponseStatusFailure {
log.Info(fmt.Sprintf("Failed to discover extension %q: got failure response with message %v", extensionConfig.Name, response.GetMessage()))
// Don't add the message to the error as it is may be unique causing too many reconciliations. Ref: https://github.com/kubernetes-sigs/cluster-api/issues/6921
return nil, errors.Errorf("failed to discover extension %q: got failure response", extensionConfig.Name)
return nil, errors.Errorf("failed to discover extension %q: got failure response, please check controller logs for errors", extensionConfig.Name)
}

// Check to see if the response is valid.
Expand Down Expand Up @@ -366,7 +366,7 @@ func (c *client) CallExtension(ctx context.Context, hook runtimecatalog.Hook, fo
if response.GetStatus() == runtimehooksv1.ResponseStatusFailure {
log.Info(fmt.Sprintf("Failed to call extension handler %q: got failure response with message %v", name, response.GetMessage()))
// Don't add the message to the error as it is may be unique causing too many reconciliations. Ref: https://github.com/kubernetes-sigs/cluster-api/issues/6921
return errors.Errorf("failed to call extension handler %q: got failure response", name)
return errors.Errorf("failed to call extension handler %q: got failure response, please check controller logs for errors", name)
}

if retryResponse, ok := response.(runtimehooksv1.RetryResponseObject); ok && retryResponse.GetRetryAfterSeconds() != 0 {
Expand Down