Skip to content

✨ Add in-place updates support for machine controller #12831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2025
Merged

✨ Add in-place updates support for machine controller #12831

merged 1 commit into from
Nov 3, 2025

Conversation

@alexander-demicev
Copy link
Contributor

@alexander-demicev alexander-demicev commented Oct 8, 2025

What this PR does / why we need it:
Part of #12291

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Oct 8, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 8, 2025
@sbueringer sbueringer added the area/machine Issues or PRs related to machine lifecycle management label Oct 8, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Oct 8, 2025
@sbueringer sbueringer mentioned this pull request Oct 8, 2025
Open
79 tasks
sbueringer
sbueringer reviewed Oct 13, 2025
View reviewed changes
@alexander-demicev alexander-demicev force-pushed the machinecontroller branch 2 times, most recently from a88faa8 to ed1835e Compare October 15, 2025 10:41
sbueringer
sbueringer reviewed Oct 20, 2025
View reviewed changes
@alexander-demicev
Copy link
Contributor Author

alexander-demicev commented Oct 22, 2025

@sbueringer all comments addressed

@sbueringer
Copy link
Member

sbueringer commented Oct 23, 2025

I think you can go ahead and add unit test coverage

sbueringer
sbueringer reviewed Oct 24, 2025
View reviewed changes
furkatgofurov7
furkatgofurov7 reviewed Oct 27, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 29, 2025
@alexander-demicev alexander-demicev marked this pull request as ready for review October 29, 2025 15:04
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 29, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sivchari October 29, 2025 15:05
sbueringer
sbueringer reviewed Oct 31, 2025
View reviewed changes
@alexander-demicev alexander-demicev force-pushed the machinecontroller branch 2 times, most recently from 1cc7470 to b6fd638 Compare November 3, 2025 09:35
sbueringer
sbueringer reviewed Nov 3, 2025
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last one from my side

furkatgofurov7
furkatgofurov7 reviewed Nov 3, 2025
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the PR

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 3, 2025

LGTM label has been added.

Git tree hash: 472d13609eb29aea21b9cb3de7ffed902b29d169

@alexander-demicev alexander-demicev force-pushed the machinecontroller branch 2 times, most recently from fb62c55 to 06e2193 Compare November 3, 2025 11:16
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2025
fabriziopandini
fabriziopandini reviewed Nov 3, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits from my side + one question

@sbueringer
Copy link
Member

sbueringer commented Nov 3, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 3, 2025

LGTM label has been added.

Git tree hash: 701505f13ae97ef73a923f58216df4ba4baaff0b

@sbueringer
Copy link
Member

sbueringer commented Nov 3, 2025

/test pull-cluster-api-e2e-main

@sbueringer
Copy link
Member

sbueringer commented Nov 3, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6c59755 into kubernetes-sigs:main Nov 3, 2025
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@richardcase richardcase Awaiting requested review from richardcase

@sivchari sivchari Awaiting requested review from sivchari

@furkatgofurov7 furkatgofurov7 Awaiting requested review from furkatgofurov7

Assignees

@sbueringer sbueringer

@furkatgofurov7 furkatgofurov7

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machine Issues or PRs related to machine lifecycle management cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

5 participants

@alexander-demicev @k8s-ci-robot @sbueringer @fabriziopandini @furkatgofurov7