Skip to content

Conversation

@chrischdi
Copy link
Member

What this PR does / why we need it:

Updates the metrics configuration to use the v1beta2 api version instead of v1beta1.

Small adjustments to metrics:

  • Added ClusterClass classref namespace metric (capi_clusterclass_spec_topology_classref_namespace)
  • renamed capi_clusterclass_spec_topology_class to capi_clusterclass_spec_topology_classref_name
  • dropped metrics related to .Status.UnavailableReplicas (deprecated)
  • dropped metrics related to .Status.UpdatedReplicas
  • Added metrics for .Status.UpToDateReplicas
  • MHC: removed label maxUnhealthy, added remediation_triggerif_unhealthylessthanorequalto and remediation_triggerif_unhealthyrange

Adjustments to dashboards:

  • For KCP and MD: use uptodate metric instead of updated

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Part of:

/area ci

@k8s-ci-robot k8s-ci-robot added area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 15, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 15, 2025
@chrischdi chrischdi added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 15, 2025
@chrischdi chrischdi changed the title 🌱 update metrics configuration to v1beta2 🌱 [WIP] update metrics configuration to v1beta2 Aug 15, 2025
@chrischdi
Copy link
Member Author

/hold

Want to verify locally

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2025
@chrischdi chrischdi changed the title 🌱 [WIP] update metrics configuration to v1beta2 🌱 update metrics configuration to v1beta2 Aug 15, 2025
@chrischdi
Copy link
Member Author

verified locally.

/assign @sbueringer

@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2025
@chrischdi chrischdi force-pushed the v1beta2-update-metrics branch from d0ca625 to f6429d0 Compare September 3, 2025 11:54
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrischdi Thx, very last nit

@sbueringer
Copy link
Member

Thank you very much!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ab185ddebbc07025cf1ca8a7ea2637d9510593ac

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0db4bf4 into kubernetes-sigs:main Sep 17, 2025
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants