🌱 GitLab can use both Path and RawPath

[aetertinas9]

What this PR does / why we need it:

#9481

This is a bug that occurred in the above link and has not been resolved for a long time. However, it needs to be included in the release version, so I am opening a new issue.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10605

/area clusterctl
--> area/clusterctl Issues or PRs related to clusterctl

[k8s-ci-robot]

Hi @aetertinas9. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[aetertinas9]

I apologize for any shortcomings

[chrischdi]

/retitle 🌱 GitLab can use both Path and RawPath

[chrischdi]

/ok-to-test

[chrischdi]

/lgtm

Question: You did test this version locally too with a gitlab repository, right?

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: ca8335f448e83cd95fa7c2d9e031462ac6e59e09

[aetertinas9]

@chrischdi
That's right. I built it locally and tested it with project ID as {projectSlug} in versions v1.7.1 and v1.7.2, and I tested the escaped full path using test code.

[Jont828]

@aetertinas9 Looks good overall. Have you tested this locally to verify that existing behavior would still work with this change?

[aetertinas9]

@Jont828
The existing behavior has been verified to work correctly with the test code and some additional cases (Infrastructure openStack & Packet, master node and worker node have been completed.)

It is also recommended to call EscapedPath instead of reading u.RawPath directly here

[chrischdi]

@aetertinas9 can you please rebase this ans squash the commits?

Merge commits should not be in PRs :-)

[aetertinas9]

@chrischdi
Sure, I rebase and squash the commits. Thank you for pointing that out!

[chrischdi]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: e085135cb900335953157999bacf40f155fa9531

[chrischdi]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chrischdi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment