🐛 Remove invalid kustomizeconfig #3685
Merged
+0
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change has no effect on the output of this kustomization because the removed configuration was redundant. However, it fixes a bug which can be triggered when using this kustomization as a base for another kustomization. We remove 2 types of configuration. The first is redundant, the second is incorrect and triggers the bug. Firstly we remove nameReference configurations which specify references which are already part of kustomize's defaults. These were found in: * config/govmomi/webhook/kustomizeconfig.yaml * config/supervisor/webhook/kustomizeconfig.yaml Secondly we remove all namespace configurations as these were all incorrect. These directed the namespace transformer to update webhooks/clientConfig/service/namespace. However, this is not the intended function of the namespace transformer: it should only set the namespace directly on objects and allow references to be updated automatically by nameReference. Configuring it to update a reference directly leaves kustomize with inconsistent internal state. Depending on execution order this can cause a subsequent transformation to fail to update the reference when it makes further changes to the Service object.
k8s-ci-robot
added
cncf-cla: yes
mdbooth
changed the title
Member
|
/test help |
Contributor
|
@chrischdi: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
|
Tested via: kustomize build --load-restrictor LoadRestrictionsNone config/default > $OUTDIR/default.yaml
kustomize build --load-restrictor LoadRestrictionsNone config/supervisor > $OUTDIR/supervisor.yamlAnd comparing outputs, there was no diff 👍 /test pull-cluster-api-provider-vsphere-e2e-govmomi-main |
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Member
|
/hold Pending CI |
Contributor
|
LGTM label has been added. Git tree hash: 4f6e44836acdd87448e00682425b21ed74b2fbf8
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Member
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Member
|
Thx! |
This was referenced Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change has no effect on the output of this kustomization because
the removed configuration was redundant. However, it fixes a bug which
can be triggered when using this kustomization as a base for another
kustomization.
We remove 2 types of configuration. The first is redundant, the second
is incorrect and triggers the bug.
Firstly we remove nameReference configurations which specify references
which are already part of kustomize's defaults. These were found in:
Secondly we remove all namespace configurations as these were all
incorrect. These directed the namespace transformer to update
webhooks/clientConfig/service/namespace. However, this is not the
intended function of the namespace transformer: it should only set the
namespace directly on objects and allow references to be updated
automatically by nameReference. Configuring it to update a reference
directly leaves kustomize with inconsistent internal state. Depending on
execution order this can cause a subsequent transformation to fail to
update the reference when it makes further changes to the Service
object.
This issue is common amongst multiple providers, likely because it was present in an early version of the kubebuilder templates.
This PR is based on kubernetes-sigs/cluster-api-provider-azure#5982
To confirm that the removed configuration was redundant: