Skip to content

Conversation

@laozc
Copy link
Member

@laozc laozc commented Nov 17, 2025

What this PR does / why we need it:

Add new fields to opt-in EncryptionClass name on volumes

    // +optional
    EncryptionClassName *string `json:"encryptionClassName,omitempty"`

and VMOp.Crypto

    // Crypto describes the desired encryption state of the VirtualMachine.
	// +optional
	Crypto *VirtualMachineCryptoSpec `json:"crypto,omitempty"`

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 17, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 17, 2025
@laozc laozc changed the title feat: Add supports to Crypto Spec in VMOp VirtualMachine and PVC ✨ Add supports to Crypto Spec in VMOp VirtualMachine and PVC Nov 17, 2025
@laozc laozc force-pushed the encryption-class branch 7 times, most recently from 54f5a3c to d044a65 Compare November 17, 2025 06:45
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 17, 2025
@laozc laozc force-pushed the encryption-class branch 8 times, most recently from d87c2ea to 84c63df Compare November 18, 2025 01:16
Copy link

@zjs zjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM

// storage class.
// +optional
// +kubebuilder:validation:MaxLength=253
EncryptionClassName *string `json:"encryptionClassName,omitempty"`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: It may be useful to document somewhere (perhaps just in the PR description) why this is a *string instead of the string used by VM Operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants