-
Notifications
You must be signed in to change notification settings - Fork 304
✨ Add supports to Crypto Spec in VMOp VirtualMachine and PVC #3680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
54f5a3c to
d044a65
Compare
d044a65 to
e10f947
Compare
d87c2ea to
84c63df
Compare
84c63df to
6a0a4f2
Compare
zjs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM
| // storage class. | ||
| // +optional | ||
| // +kubebuilder:validation:MaxLength=253 | ||
| EncryptionClassName *string `json:"encryptionClassName,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: It may be useful to document somewhere (perhaps just in the PR description) why this is a *string instead of the string used by VM Operator.
What this PR does / why we need it:
Add new fields to opt-in
EncryptionClassname on volumesand
VMOp.CryptoWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #