Skip to content

🌱 CI: clear /etc/sysconfig/kubelet to ensure --pod-infra-container-image is not set #3661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2025
Merged

🌱 CI: clear /etc/sysconfig/kubelet to ensure --pod-infra-container-image is not set #3661

merged 1 commit into from
Nov 4, 2025

Conversation

@chrischdi
Copy link
Member

@chrischdi chrischdi commented Nov 4, 2025

What this PR does / why we need it:

CI failing when creating a machine with v1.35 due to kubelet flag --pod-infra-container-image being set while it was removed for v1.35.

Note: the /etc/sysconfig/kubelet file only contains this single flag for CAPV.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@chrischdi
Copy link
Member Author

chrischdi commented Nov 4, 2025

/test help

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2025

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main

/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main

/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-34-1-35-main

/test pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main

/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main

/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main

/test pull-cluster-api-provider-vsphere-e2e-supervisor-main

/test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-34-1-35-main

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main

/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

/test pull-cluster-api-provider-vsphere-test-main

/test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-vsphere-apidiff-main

/test pull-cluster-api-provider-vsphere-janitor-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-vsphere-apidiff-main

pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main

pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main

pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main

pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

pull-cluster-api-provider-vsphere-test-main

pull-cluster-api-provider-vsphere-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 4, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Nov 4, 2025

/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-34-1-35-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-34-1-35-main

@chrischdi chrischdi force-pushed the pr-fix-1-35-kubelet-pod-infra-container-image branch from 6b1a1d1 to f3ae313 Compare November 4, 2025 10:47
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 4, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Nov 4, 2025

/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-34-1-35-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-34-1-35-main

@chrischdi
Copy link
Member Author

chrischdi commented Nov 4, 2025

I think these are unrelated flakes.

It must be for vcsim at least.

/retest

@sbueringer sbueringer mentioned this pull request Nov 4, 2025
Open
28 tasks
@sbueringer
Copy link
Member

sbueringer commented Nov 4, 2025

Thank you very much!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2025

LGTM label has been added.

Git tree hash: aa12dc2601ef5520b0b1cbaf75d4be4b2e77431d

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Nov 4, 2025

/retest

Some other CI issue

* Failed to connect to 192.168.31.2 port 443 after 2000 ms: Timeout was reached
* Closing connection 0
Failed to reach https://192.168.31.2/sdk. Retrying in 1s (300/300)

@sbueringer
Copy link
Member

sbueringer commented Nov 4, 2025

We'll get there :)

@k8s-ci-robot k8s-ci-robot merged commit d6833ff into kubernetes-sigs:main Nov 4, 2025
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Nov 4, 2025
sbueringer pushed a commit to sbueringer/cluster-api-provider-vsphere that referenced this pull request Nov 5, 2025
@k8s-ci-robot @sbueringer
Merge pull request kubernetes-sigs#3661 from chrischdi/pr-fix-1-35-ku…
89a100a 
…belet-pod-infra-container-image

🌱 CI: clear /etc/sysconfig/kubelet to ensure --pod-infra-container-image is not set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gab-satchi gab-satchi Awaiting requested review from gab-satchi

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.15

Development

Successfully merging this pull request may close these issues.

3 participants

@chrischdi @k8s-ci-robot @sbueringer