Skip to content

Conversation

@sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
xref: https://github.com/sbueringer/cluster-api-provider-vsphere/actions/runs/16117480054/job/45474652909

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Signed-off-by: Stefan Büringer [email protected]
@k8s-ci-robot k8s-ci-robot requested a review from MaxRink July 7, 2025 14:41
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 7, 2025
@k8s-ci-robot k8s-ci-robot requested a review from vrabbi July 7, 2025 14:41
@sbueringer
Copy link
Member Author

/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 7, 2025
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1e8043f09ee869e97814563c2c57cd29ab58c9b0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit 091aa19 into kubernetes-sigs:main Jul 8, 2025
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Jul 8, 2025
@sbueringer sbueringer deleted the pr-fix-broken-links branch July 8, 2025 09:09
@sbueringer
Copy link
Member Author

Wish me luck...

@sbueringer
Copy link
Member Author

/cherry-pick release-1.13

@sbueringer
Copy link
Member Author

/cherry-pick release-1.12

@sbueringer
Copy link
Member Author

/cherry-pick release-1.11

@k8s-infra-cherrypick-robot

@sbueringer: #3538 failed to apply on top of branch "release-1.13":

Applying: Fix broken links
error: patch failed: docs/proposal/20220929-ipam-support.md:21
error: docs/proposal/20220929-ipam-support.md: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Using index info to reconstruct a base tree...
Patch failed at 0001 Fix broken links

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@sbueringer: #3538 failed to apply on top of branch "release-1.12":

Applying: Fix broken links
error: patch failed: docs/proposal/20220929-ipam-support.md:21
error: docs/proposal/20220929-ipam-support.md: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Using index info to reconstruct a base tree...
A	docs/proposal/20241003-data-disk-support.md
Patch failed at 0001 Fix broken links

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@sbueringer: #3538 failed to apply on top of branch "release-1.11":

Applying: Fix broken links
error: patch failed: docs/proposal/20220929-ipam-support.md:21
error: docs/proposal/20220929-ipam-support.md: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Using index info to reconstruct a base tree...
A	docs/proposal/20241003-data-disk-support.md
Patch failed at 0001 Fix broken links

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants