Skip to content

Conversation

@rikatz
Copy link
Member

@rikatz rikatz commented Oct 31, 2024

What this PR does / why we need it:

On some networks IPv6 is announced via RA. Networkd (and maybe netplan) separates DHCPv6 and RA enablement, meaning that even when users set to ignore/disable DHCPv6, IPv6 is still configured on the Host VM if there is some Route Advertisement for IPv6.

Turns out on some setups this may break the desired behavior, as DNSv6 and others may also end up being configured on the node using IPv6.

This PR intends to do the following changes:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 31, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 31, 2024
@rikatz rikatz changed the title Proper ignore IPv6 announcements when IPv6 is not requested 🐛 Proper ignore IPv6 announcements when IPv6 is not requested Oct 31, 2024
@rikatz
Copy link
Member Author

rikatz commented Oct 31, 2024

/cc @sbueringer @fabriziopandini

@rikatz
Copy link
Member Author

rikatz commented Nov 1, 2024

team-cluster-api#35 this is passing :)

@rikatz
Copy link
Member Author

rikatz commented Nov 1, 2024

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ec0595850d07489a49d0964e754d341f4931e9cc

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 097c022 into kubernetes-sigs:main Nov 4, 2024
17 of 18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants