Skip to content

🌱 Replace CAPI's clustercache tracker by the new clustercache #3236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2024
Merged

🌱 Replace CAPI's clustercache tracker by the new clustercache #3236

merged 2 commits into from
Nov 5, 2024

Conversation

@chrischdi
Copy link
Member

@chrischdi chrischdi commented Oct 25, 2024

What this PR does / why we need it:

Removes usage of the deprecated remote.ClusterCacheTracker and related functions.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@chrischdi
Copy link
Member Author

chrischdi commented Oct 25, 2024

/test help

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 25, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 25, 2024

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
  • /test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main
  • /test pull-cluster-api-provider-vsphere-test-main
  • /test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-apidiff-main
  • pull-cluster-api-provider-vsphere-test-main
  • pull-cluster-api-provider-vsphere-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 25, 2024
@chrischdi chrischdi mentioned this pull request Oct 25, 2024
Closed
@chrischdi
Copy link
Member Author

chrischdi commented Oct 25, 2024

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

@chrischdi
Copy link
Member Author

chrischdi commented Oct 25, 2024

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main

E1025 12:40:30.036079 1 mux.go:452] "Failed to start WorkloadClusterListener" err="accept tcp [::]:20000: use of closed network connection" listenerName="default/ipclaim-qqmrhnp7xbhwnvwr4qmw9knxhpfgm2tl" address="https://10.244.0.12:20000"

@chrischdi
Copy link
Member Author

chrischdi commented Oct 25, 2024

/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

failed before upgrade (CAPV 1.9.6)

@fabriziopandini
Copy link
Member

fabriziopandini commented Oct 25, 2024

/lgtm
@sbueringer for a final check

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 25, 2024

LGTM label has been added.

Git tree hash: 64ecff5369da795216796fe334ea57b54183d02f

@sbueringer
Copy link
Member

sbueringer commented Oct 28, 2024

Tests on mirror are not green

@sbueringer
Copy link
Member

sbueringer commented Oct 28, 2024

/hold

Tests on mirror are consistently failing. I'll run them a few more times, but we'll probably have to debug them to figure out what's going on

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2024
@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 4, 2024
@sbueringer
Copy link
Member

sbueringer commented Nov 4, 2024

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

@sbueringer
Copy link
Member

sbueringer commented Nov 4, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2024

LGTM label has been added.

Git tree hash: 7ad527ef3b20f15239217d92f53d1da0634fcc79

@sbueringer
Fix govmomi e2e tests
c04dcff 
Signed-off-by: Stefan Büringer [email protected]
@sbueringer
Copy link
Member

sbueringer commented Nov 4, 2024

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

@sbueringer
Copy link
Member

sbueringer commented Nov 4, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2024
@sbueringer
Copy link
Member

sbueringer commented Nov 4, 2024

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2024

@chrischdi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-apidiff-main c04dcff link false /test pull-cluster-api-provider-vsphere-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fabriziopandini
Copy link
Member

fabriziopandini commented Nov 4, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2024

LGTM label has been added.

Git tree hash: 01b04608385c776d36a6f1c1a5576b993d8056b6

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@sbueringer
Copy link
Member

sbueringer commented Nov 5, 2024

Tests are all green

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7ac01a6 into kubernetes-sigs:main Nov 5, 2024
12 of 13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Nov 5, 2024
@chrischdi chrischdi mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@vrabbi vrabbi Awaiting requested review from vrabbi

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

4 participants

@chrischdi @k8s-ci-robot @fabriziopandini @sbueringer