Skip to content

🌱 main.go: add flags for webhook cert-name and -key #3215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2024
Merged

🌱 main.go: add flags for webhook cert-name and -key #3215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
908c624
main.go: add flags for webhook cert-name and -key
chrischdi Oct 4, 2024
d9d4e70
main.go set real default webhook port
chrischdi Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ var (
defaultSyncPeriod = manager.DefaultSyncPeriod
defaultLeaderElectionID = manager.DefaultLeaderElectionID
defaultPodName = manager.DefaultPodName
defaultWebhookPort = manager.DefaultWebhookServiceContainerPort
)

// InitFlags initializes the flags.
Expand Down Expand Up @@ -199,11 +198,17 @@ func InitFlags(fs *pflag.FlagSet) {
fs.IntVar(&clusterCacheTrackerClientBurst, "clustercachetracker-client-burst", 30,
"Maximum number of queries that should be allowed in one burst from the cluster cache tracker clients to the Kubernetes API server of workload clusters.")

fs.IntVar(&webhookOpts.Port, "webhook-port", defaultWebhookPort,
"Webhook Server port")
fs.IntVar(&webhookOpts.Port, "webhook-port", 9443,
"Webhook Server port.")

fs.StringVar(&webhookOpts.CertDir, "webhook-cert-dir", "/tmp/k8s-webhook-server/serving-certs/",
"Webhook cert dir, only used when webhook-port is specified.")
"Webhook cert dir.")

fs.StringVar(&webhookOpts.CertName, "webhook-cert-name", "tls.crt",
"Webhook cert name.")

fs.StringVar(&webhookOpts.KeyName, "webhook-key-name", "tls.key",
"Webhook key name.")

fs.StringVar(&managerOpts.HealthProbeBindAddress, "health-addr", ":9440",
"The address the health endpoint binds to.",
Expand Down
4 changes: 0 additions & 4 deletions pkg/manager/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ import "time"
const (
defaultPrefix = "capv-"

// DefaultWebhookServiceContainerPort is the default value for the eponymous
// manager option.
DefaultWebhookServiceContainerPort = 0

// DefaultSyncPeriod is the default value for the eponymous
// manager option.
DefaultSyncPeriod = time.Minute * 10
Expand Down