🌱 Bump e2e to use k8s v1.34.2 #2836
Merged
+15
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/hold
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Contributor
Author
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
Contributor
Author
|
Ok so there is the downside of using a kind cluster for clusterctl upgrade. We need to make sure we have a node image with the correct version for it. |
lentzi90
force-pushed
the
lentzi90/k8s-v1.34
branch
2 times, most recently
from
7066450 to
cc1c460
Compare
Contributor
Author
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
Since we use kind for the clusterctl upgrade tests, we need to use a kubernetes version that has a kind node image available also. I have added a separate variable for this. (We could also build the kind image but that takes time and resources.) Signed-off-by: Lennart Jern <[email protected]>
lentzi90
force-pushed
the
lentzi90/k8s-v1.34
branch
from
cc1c460 to
b004100
Compare
Contributor
Author
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
Contributor
Author
|
Ok this works |
k8s-ci-robot
removed
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Run e2e tests with k8s v1.34.2. Upgrades from v1.33.1.
Also changes the image names to not include the versions. It felt a bit unnecessary to constantly change both the URLs and the names.
Since we use kind for the clusterctl upgrade tests, we need
to use a kubernetes version that has a kind node image available also.
I have added a separate variable for this.
(We could also build the kind image but that takes time and resources.)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: