Skip to content

Further dalec spec fixes #5978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2025
Merged

Further dalec spec fixes #5978

merged 1 commit into from
Nov 20, 2025
+188 −64

Conversation

@willie-yao
Copy link
Contributor

@willie-yao willie-yao commented Nov 17, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR adds some further fixes for issues regarding variables not being exported correctly and formatting issues with http proxy.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 17, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.53%. Comparing base (5db07e5) to head (1ad621f).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5978      +/-   ##
==========================================
- Coverage   44.54%   44.53%   -0.01%     
==========================================
  Files         279      279              
  Lines       25140    25140              
==========================================
- Hits        11199    11197       -2     
- Misses      13128    13130       +2     
  Partials      813      813

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jackfrancis
jackfrancis approved these changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 17, 2025

LGTM label has been added.

Git tree hash: dff217e98aed94d3d73eb3bf7bac4a47c88e498f

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2025
@jackfrancis
Copy link
Contributor

jackfrancis commented Nov 17, 2025

/hold

in case there are non-required tests currently running that we want to wait for

@willie-yao feel free to release hold when you're ready to merge

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2025
mboersma
mboersma approved these changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

templates/test/ci/prow-dalec-custom-builds/patches/control-plane-custom-builds.yaml
path: /spec/kubeadmConfigSpec/initConfiguration/nodeRegistration/ignorePreflightErrors
value:
- HTTPProxyCIDR

Copy link
Contributor

@mboersma mboersma Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline?

Copy link
Contributor Author

@willie-yao willie-yao Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean I should remove the existing newline? Or add one somewhere

Copy link
Contributor

@mboersma mboersma Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to add one at the end of the file. GitHub flags "no final newline" with a little red icon, so I pointed it out, but it's trivial so don't worry about it.

Copy link
Contributor Author

@willie-yao willie-yao Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the newline at my end so I think it's okay?

Image

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2025
@willie-yao
Copy link
Contributor Author

willie-yao commented Nov 18, 2025

/hold testing a few formatting things

@alimaazamat
Copy link
Contributor

alimaazamat commented Nov 19, 2025

/approve

jackfrancis
jackfrancis approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 19, 2025

LGTM label has been added.

Git tree hash: de1b19ceca105cacfb3b8b7e4f57f834beed5b7f

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alimaazamat, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marosset
Copy link
Contributor

marosset commented Nov 20, 2025

/lgtm

@mboersma
Copy link
Contributor

mboersma commented Nov 20, 2025

/retest

This seems like an unrelated flake, but something we should investigate. I'll open an issue.

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/5978/pull-cluster-api-provider-azure-e2e-workload-upgrade/1991291898312003584

  The function passed to Eventually returned the following error:
      <*errors.fundamental | 0xc005a88408>: 
      old version instances remain. Expected 2 instances at version v1.32.10. Got version list: [v1.31.14 v1.32.10]
      {
          msg: "old version instances remain. Expected 2 instances at version v1.32.10. Got version list: [v1.31.14 v1.32.10]",
          stack: [0x442561e, 0x207d506, 0x207c619, 0x3d7d7df, 0x3d7e882, 0x3d7bb65, 0x44252f3, 0x4423b55, 0x5163851, 0x3d56493, 0x3d6bdd3, 0x1ff3ea1],
      }

@jackfrancis
Copy link
Contributor

jackfrancis commented Nov 20, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 81b8d76 into kubernetes-sigs:main Nov 20, 2025
29 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Nov 20, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackfrancis jackfrancis jackfrancis approved these changes

@nojnhuh nojnhuh Awaiting requested review from nojnhuh

@mboersma mboersma Awaiting requested review from mboersma

Assignees

@mboersma mboersma

@jackfrancis jackfrancis

@marosset marosset

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

CAPZ Planning
Status: Done

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

6 participants

@willie-yao @k8s-ci-robot @jackfrancis @alimaazamat @marosset @mboersma