Skip to content

Conversation

@nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Oct 24, 2025

What type of PR is this?
/kind flake

What this PR does / why we need it:

The API server ILB e2e test creates a DaemonSet to test the ILB but fails immediately if not all of those Pods exist by the time it lists them for the first time. Since the DaemonSet will create the Pods asynchronously, this PR makes that check retriable.

This should address flakes we've seen in that test lately: https://storage.googleapis.com/k8s-triage/index.html?date=2025-10-24&pr=1&text=expected%20number%20of%20worker%20node-debug%20daemonset%20pods%3A&job=azure

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 24, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 24, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2025
@nojnhuh nojnhuh mentioned this pull request Oct 24, 2025
4 tasks
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 24, 2025

I didn't try this locally, so I'd like to get a few runs of the optional job in to make sure this flake is gone.

/hold
/test pull-cluster-api-provider-azure-e2e-optional

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2025
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.53%. Comparing base (e22796f) to head (3324bc2).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5943      +/-   ##
==========================================
- Coverage   44.60%   44.53%   -0.07%     
==========================================
  Files         279      279              
  Lines       25132    25140       +8     
==========================================
- Hits        11209    11197      -12     
- Misses      13110    13130      +20     
  Partials      813      813              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation bot moved this from Todo to Wait-On-Author in CAPZ Planning Oct 24, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2025
@k8s-ci-robot k8s-ci-robot changed the title Retry in ILB e2e test when test pods aren't created yet Retry more error conditions in ILB e2e test Oct 24, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 24, 2025

/test pull-cluster-api-provider-azure-e2e-optional

Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1b5353c3d3bd27d65ae53e5862365d7315fc9441

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 24, 2025

/test pull-cluster-api-provider-azure-e2e-optional

1 similar comment
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 24, 2025

/test pull-cluster-api-provider-azure-e2e-optional

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 24, 2025

Tests looking good.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit f927eb2 into kubernetes-sigs:main Oct 25, 2025
24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Oct 25, 2025
@github-project-automation github-project-automation bot moved this from Wait-On-Author to Done in CAPZ Planning Oct 25, 2025
@nojnhuh nojnhuh deleted the ilb-flake branch October 27, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants