-
Notifications
You must be signed in to change notification settings - Fork 461
Retry more error conditions in ILB e2e test #5943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I didn't try this locally, so I'd like to get a few runs of the optional job in to make sure this flake is gone. /hold |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5943 +/- ##
==========================================
- Coverage 44.60% 44.53% -0.07%
==========================================
Files 279 279
Lines 25132 25140 +8
==========================================
- Hits 11209 11197 -12
- Misses 13110 13130 +20
Partials 813 813 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/test pull-cluster-api-provider-azure-e2e-optional |
jackfrancis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
LGTM label has been added. Git tree hash: 1b5353c3d3bd27d65ae53e5862365d7315fc9441
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-cluster-api-provider-azure-e2e-optional |
1 similar comment
|
/test pull-cluster-api-provider-azure-e2e-optional |
|
Tests looking good. /hold cancel |
What type of PR is this?
/kind flake
What this PR does / why we need it:
The API server ILB e2e test creates a DaemonSet to test the ILB but fails immediately if not all of those Pods exist by the time it lists them for the first time. Since the DaemonSet will create the Pods asynchronously, this PR makes that check retriable.
This should address flakes we've seen in that test lately: https://storage.googleapis.com/k8s-triage/index.html?date=2025-10-24&pr=1&text=expected%20number%20of%20worker%20node-debug%20daemonset%20pods%3A&job=azure
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: