-
Notifications
You must be signed in to change notification settings - Fork 461
Fix bash syntax for make cleanup-workload-identity #5942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bash syntax for make cleanup-workload-identity #5942
Conversation
|
/assign @willie-yao In case this might have some unintended side effects. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5942 +/- ##
==========================================
- Coverage 44.59% 44.54% -0.05%
==========================================
Files 279 279
Lines 25129 25140 +11
==========================================
- Hits 11206 11199 -7
- Misses 13110 13128 +18
Partials 813 813 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/test pull-cluster-api-provider-azure-e2e |
|
Now that the cleanup is actually running, I see it's trying to delete a different resource group than the one it created. /hold |
e489aaa to
4a1df42
Compare
|
@nojnhuh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4a1df42 to
30bd7ab
Compare
30bd7ab to
2280648
Compare
jackfrancis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
tests will tell the tale
|
LGTM label has been added. Git tree hash: 089291f7eb075489546f492dac382f20bfffeeeb
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Cleanup appears to be working properly now for conformance and e2e jobs. /hold cancel |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This fixes an annoying error I started seeing recently in e2e logs that gets highlighted, e.g. from https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/periodic-cluster-api-provider-azure-e2e-aks-main/1981117577597816832
I'm guessing this started with #5883.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: