Skip to content

Conversation

@nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Oct 24, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:

This fixes an annoying error I started seeing recently in e2e logs that gets highlighted, e.g. from https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/periodic-cluster-api-provider-azure-e2e-aks-main/1981117577597816832

 bash: -c: line 4: syntax error: unexpected end of file 

I'm guessing this started with #5883.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Oct 24, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 24, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 24, 2025

/assign @willie-yao

In case this might have some unintended side effects.

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.54%. Comparing base (398697b) to head (2280648).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5942      +/-   ##
==========================================
- Coverage   44.59%   44.54%   -0.05%     
==========================================
  Files         279      279              
  Lines       25129    25140      +11     
==========================================
- Hits        11206    11199       -7     
- Misses      13110    13128      +18     
  Partials      813      813              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 24, 2025

/test pull-cluster-api-provider-azure-e2e
/test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts
/test pull-cluster-api-provider-azure-ci-entrypoint

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 24, 2025

Now that the cleanup is actually running, I see it's trying to delete a different resource group than the one it created. AZWI_RESOURCE_GROUP for some reason isn't being carried all the way through.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2025
@nojnhuh nojnhuh force-pushed the bash-the-inevitable branch from e489aaa to 4a1df42 Compare October 24, 2025 17:16
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 24, 2025

@nojnhuh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-conformance 4a1df42 link false /test pull-cluster-api-provider-azure-conformance

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nojnhuh nojnhuh force-pushed the bash-the-inevitable branch from 4a1df42 to 30bd7ab Compare October 24, 2025 18:04
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2025
@nojnhuh nojnhuh force-pushed the bash-the-inevitable branch from 30bd7ab to 2280648 Compare October 24, 2025 18:06
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

tests will tell the tale

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 089291f7eb075489546f492dac382f20bfffeeeb

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 24, 2025

Cleanup appears to be working properly now for conformance and e2e jobs.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5cc81a9 into kubernetes-sigs:main Oct 24, 2025
27 of 30 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Oct 24, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Oct 24, 2025
@nojnhuh nojnhuh deleted the bash-the-inevitable branch October 24, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants