Skip to content

Remove go-autorest once and for all #5939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

Remove go-autorest once and for all #5939

merged 1 commit into from
Oct 24, 2025
+107 −300

Conversation

@nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Oct 23, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

This PR removes the last places we were using go-autorest which has been EOL for 2 years already?

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2974

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

Removed last usage of the deprecated go-autorest libraries.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 23, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 23, 2025
nojnhuh
nojnhuh commented Oct 23, 2025
View reviewed changes
azure/scope/clients.go
Comment on lines -130 to -138
setValue(s, "AZURE_TENANT_ID")
setValue(s, "AZURE_AUXILIARY_TENANT_IDS")
setValue(s, "AZURE_CLIENT_ID")
setValue(s, "AZURE_CLIENT_SECRET")
setValue(s, "AZURE_CERTIFICATE_PATH")
setValue(s, "AZURE_CERTIFICATE_PASSWORD")
setValue(s, "AZURE_USERNAME")
setValue(s, "AZURE_PASSWORD")
setValue(s, "AZURE_AD_RESOURCE")
Copy link
Contributor Author

@nojnhuh nojnhuh Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT none of these environment variables mean anything to the SDKv2 clients that we use.

@jackfrancis
Copy link
Contributor

jackfrancis commented Oct 23, 2025

/assign @mboersma

love to see this 🎉

@codecov
Copy link

codecov bot commented Oct 23, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.53%. Comparing base (126d5fb) to head (2685a98).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
azure/scope/clients.go 50.00% 23 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5939      +/-   ##
==========================================
- Coverage   46.94%   44.53%   -2.42%     
==========================================
  Files         279      279              
  Lines       29688    25137    -4551     
==========================================
- Hits        13937    11194    -2743     
+ Misses      14938    13130    -1808     
  Partials      813      813

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 24, 2025

/retest

mboersma
mboersma approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Hooray! Thanks @nojnhuh!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 24, 2025

LGTM label has been added.

Git tree hash: 233692d99458253dbe8403f87d15df6ae4d48579

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7df6f16 into kubernetes-sigs:main Oct 24, 2025
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Oct 24, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mboersma mboersma mboersma approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@marosset marosset Awaiting requested review from marosset

Assignees

@mboersma mboersma

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

CAPZ Planning
Status: Done

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

Azure/go-autorest will soon be unsupported

4 participants

@nojnhuh @jackfrancis @k8s-ci-robot @mboersma