Skip to content

Conversation

@k8s-infra-cherrypick-robot

This is an automated cherry-pick of #5200

/assign enxebre

Allows Service Principal with Certificate authentication to work with a path to the certificate.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 4, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jackfrancis for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2024
@k8s-ci-robot
Copy link
Contributor

@k8s-infra-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e-v1beta1 a6f53dd link true /test pull-cluster-api-provider-azure-e2e-v1beta1
pull-cluster-api-provider-azure-build-v1beta1 a6f53dd link true /test pull-cluster-api-provider-azure-build-v1beta1
pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1 a6f53dd link true /test pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1
pull-cluster-api-provider-azure-e2e-aks-v1beta1 a6f53dd link true /test pull-cluster-api-provider-azure-e2e-aks-v1beta1
pull-cluster-api-provider-azure-ci-entrypoint-v1beta1 a6f53dd link true /test pull-cluster-api-provider-azure-ci-entrypoint-v1beta1
pull-cluster-api-provider-azure-test-v1beta1 a6f53dd link true /test pull-cluster-api-provider-azure-test-v1beta1

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nojnhuh
Copy link
Contributor

nojnhuh commented Nov 5, 2024

I'm somewhat hesitant to backport any change to the API, even if we're confident it's backward-compatible.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2024
@nojnhuh
Copy link
Contributor

nojnhuh commented Dec 9, 2024

This should land in the CAPZ 1.18 release soon, in case just having this in a release prompted the cherry-pick. I'm still not convinced we should be backporting this, but if that's important please reopen this or create a new PR with #5277 included.

/close

@k8s-ci-robot
Copy link
Contributor

@nojnhuh: Closed this PR.

In response to this:

This should land in the CAPZ 1.18 release soon, in case just having this in a release prompted the cherry-pick. I'm still not convinced we should be backporting this, but if that's important please reopen this or create a new PR with #5277 included.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants