Skip to content

Conversation

kbsteere
Copy link

What this PR does / why we need it:
Upgrade helm to latest fixes the following:
Medium CVE-2025-32386 GHSA-4hfp-h4cw-hj8p fixed in 3.17.3
High CVE-2025-53547 GHSA-557j-xg8c-q2mm fixed in 3.17.4
Medium CVE-2025-32387 GHSA-5xqw-8hwv-wg92 fixed in 3.17.3

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes failing PR that dependabot tried applying: https://github.com/kubernetes-sigs/cluster-api-addon-provider-helm/pull/412/files

…Upgraded cluster-api version to 1.10.4 to address go mod failures with newer packages. Refactored helmchartproxy_webhook.go and helmreleaseproxy_webhook.go due to changes in go packages

Signed-off-by: Kyle Steere <[email protected]>
Copy link

linux-foundation-easycla bot commented Jul 30, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kbsteere
Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @kbsteere!

It looks like this is your first PR to kubernetes-sigs/cluster-api-addon-provider-helm 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-addon-provider-helm has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 30, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @kbsteere. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kbsteere kbsteere changed the title 🌱 Bump helm.sh/helm/v3 from 3.16.4 to 3.18.4 🌱 Bump helm.sh/helm/v3 from 3.16.4 to 3.18.4 - Fix CVEs Jul 30, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 30, 2025
@jarias-lfx
Copy link

/easycla

@kbsteere
Copy link
Author

kbsteere commented Aug 5, 2025

@dmvolod can you review?

@dmvolod
Copy link
Member

dmvolod commented Aug 5, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 5, 2025
@dmvolod
Copy link
Member

dmvolod commented Aug 5, 2025

@dmvolod can you review?

It seems to not so easy to bump Cluster API to the v1.10.4. Please see #386 its still in progress.
@kbsteere , after it can be merged, you can continue to work on your PR.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2025
@k8s-ci-robot
Copy link
Contributor

@kbsteere: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-addon-provider-helm-verify-main 8179017 link true /test pull-cluster-api-addon-provider-helm-verify-main
pull-cluster-api-addon-provider-helm-apidiff-main 8179017 link false /test pull-cluster-api-addon-provider-helm-apidiff-main
pull-cluster-api-addon-provider-helm-capi-e2e 8179017 link false /test pull-cluster-api-addon-provider-helm-capi-e2e
pull-cluster-api-addon-provider-helm-e2e 8179017 link true /test pull-cluster-api-addon-provider-helm-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants