🐛 Try to upgrade Releases in pending states #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
nojnhuh
commented
Jul 29, 2025
| if existing.Info.Status == helmRelease.StatusPendingInstall || existing.Info.Status == helmRelease.StatusPendingUpgrade { | ||
| log.Info("Release is in a pending state, upgrading") | ||
| return true, nil | ||
| } |
There was a problem hiding this comment.
@Jont828 Is there a place I could add a test for this? The closest place I could find with existing tests was in the HelmReleaseProxy controller tests where this is fronted by a mock, so this code wouldn't actually run.
mboersma
reviewed
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes CAAPH try to upgrade Releases in
pending-installandpending-upgradestates, which could indicate that a previous attempt to install or upgrade had started and then failed.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #416