-
Notifications
You must be signed in to change notification settings - Fork 47
✨ Add HelmChartProxy spec field for mapping Kubernetes versions to Helm chart versions #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jont828 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is still a work in progress, but the version mapping was pretty straightforward to implement. I'm not sure, however, if we're going to run into situations where different versions of a chart require different values, meaning that the |
@nikParasyr Let me know if this is what you were looking for! |
See #292 for context and requesting this feature. |
@Jont828 based on code this seems to be what we are looking for! |
@jackfrancis @mboersma PTAL and share your thoughts on if this approach is in the right direction. The WIP is just something I drafted together pretty quickly. |
Hey @Jont828, are there any plans to go forward with this PR? Seems like a very useful feature for CAAPH |
@MaxFedotov Yes, I'm planning on moving forward with this soon. I spoke with @jackfrancis and he had some concerns, so I'm hoping to get a review or some feedback from him before merging. |
Hello, are there any news in regards with this MR? it's a feature we would really like |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it: Allows for users to specify a compatibility matrix so that a single HelmChartProxy can support multiple different Helm chart versions. See #292 for the work discussion that led to this change.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #