Skip to content

Conversation

Jont828
Copy link
Contributor

@Jont828 Jont828 commented Jan 23, 2025

What this PR does / why we need it: Allows for users to specify a compatibility matrix so that a single HelmChartProxy can support multiple different Helm chart versions. See #292 for the work discussion that led to this change.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jont828

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 23, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2025
@Jont828 Jont828 changed the title ✨ Add HelmChartProxy spec field for mapping Kubernetes versions to Helm chart versions ✨ [WIP] Add HelmChartProxy spec field for mapping Kubernetes versions to Helm chart versions Jan 23, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 23, 2025
@Jont828
Copy link
Contributor Author

Jont828 commented Jan 23, 2025

This is still a work in progress, but the version mapping was pretty straightforward to implement. I'm not sure, however, if we're going to run into situations where different versions of a chart require different values, meaning that the valuesTemplate spec field can't be shared. In that case, users would still have to create separate HelmChartProxies, one for each version with different values.

@Jont828
Copy link
Contributor Author

Jont828 commented Jan 23, 2025

@nikParasyr Let me know if this is what you were looking for!

@Jont828
Copy link
Contributor Author

Jont828 commented Jan 23, 2025

See #292 for context and requesting this feature.

@nikParasyr
Copy link
Contributor

@Jont828 based on code this seems to be what we are looking for!

@Jont828
Copy link
Contributor Author

Jont828 commented Jan 23, 2025

@jackfrancis @mboersma PTAL and share your thoughts on if this approach is in the right direction. The WIP is just something I drafted together pretty quickly.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 5, 2025
@Jont828 Jont828 changed the title ✨ [WIP] Add HelmChartProxy spec field for mapping Kubernetes versions to Helm chart versions ✨ Add HelmChartProxy spec field for mapping Kubernetes versions to Helm chart versions Feb 5, 2025
@MaxFedotov
Copy link

Hey @Jont828, are there any plans to go forward with this PR? Seems like a very useful feature for CAAPH

@Jont828
Copy link
Contributor Author

Jont828 commented Mar 5, 2025

@MaxFedotov Yes, I'm planning on moving forward with this soon. I spoke with @jackfrancis and he had some concerns, so I'm hoping to get a review or some feedback from him before merging.

@nikParasyr
Copy link
Contributor

Hello, are there any news in regards with this MR? it's a feature we would really like

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 25, 2025
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 24, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants