Skip to content

Conversation

@nilo19
Copy link
Contributor

@nilo19 nilo19 commented Nov 6, 2025

This reverts commit 6894905.

What type of PR is this?

/kind bug

What this PR does / why we need it:

See: AzureAD/microsoft-authentication-library-for-go#589

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

go get github.com/AzureAD/[email protected]
go mod tidy
go mod vendor

Does this PR introduce a user-facing change?

Revert "fix: China cloud endpoints (#9418)", please check https://github.com/AzureAD/microsoft-authentication-library-for-go/issues/589

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Nov 6, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 6, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: nilo19 / name: Qi Ni (5ced8a9)

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 6, 2025
@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 6, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 6, 2025
@nilo19
Copy link
Contributor Author

nilo19 commented Nov 6, 2025

Tests have been passed in #9606, except some quota issues which can be ignored.

@nilo19 nilo19 force-pushed the fix/revert-9418-1-32 branch from 877098d to 5ced8a9 Compare November 6, 2025 05:39
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 6, 2025
@nilo19
Copy link
Contributor Author

nilo19 commented Nov 6, 2025

Changes are cherrypicked from #9606 but I changed the author to me to make easyCLA pass.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19, robbiezhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer feiskyer merged commit f81cd78 into kubernetes-sigs:release-1.32 Nov 6, 2025
11 of 21 checks passed
@nilo19 nilo19 deleted the fix/revert-9418-1-32 branch November 6, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants