Skip to content

Conversation

@nilo19
Copy link
Contributor

@nilo19 nilo19 commented Nov 6, 2025

This reverts commit 6894905.

What type of PR is this?

/kind bug

What this PR does / why we need it:

See: AzureAD/microsoft-authentication-library-for-go#589

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

go get github.com/AzureAD/[email protected]
go mod tidy
go mod vendor

Does this PR introduce a user-facing change?

Revert "fix: China cloud endpoints (#9418)", please check https://github.com/AzureAD/microsoft-authentication-library-for-go/issues/589

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 6, 2025
@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 6, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 6, 2025
@nilo19 nilo19 changed the title chore: Downgrade MSAL from v1.5.0 to v1.4.2, together with other depe… [release-1.33] chore: Downgrade MSAL from v1.5.0 to v1.4.2, together with other depe… Nov 6, 2025
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, nilo19, robbiezhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f33e2eb into kubernetes-sigs:release-1.33 Nov 6, 2025
21 checks passed
@nilo19 nilo19 deleted the fix/revert-9418-1-33 branch November 6, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants