Skip to content

Conversation

@nilo19
Copy link
Contributor

@nilo19 nilo19 commented Nov 5, 2025

This reverts commit 6894905.

What type of PR is this?

/kind bug

What this PR does / why we need it:

See: AzureAD/microsoft-authentication-library-for-go#589

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

go get github.com/AzureAD/[email protected]
go mod tidy
go mod vendor

Does this PR introduce a user-facing change?

Revert "fix: China cloud endpoints (#9418)", please check https://github.com/AzureAD/microsoft-authentication-library-for-go/issues/589

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 5, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025
@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 5, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 5, 2025
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19, wonderyl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@nilo19: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-azure-unit 545a316 link true /test pull-cloud-provider-azure-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nilo19 nilo19 changed the title Revert "fix: China cloud endpoints (#9418)" chore: Downgrade MSAL from v1.5.0 to v1.4.2, together with other dependencies Nov 6, 2025
@nilo19
Copy link
Contributor Author

nilo19 commented Nov 6, 2025

Will leave master branch unchanged, only revert 1.31-1.34 release branches.

@nilo19 nilo19 closed this Nov 6, 2025
@nilo19 nilo19 deleted the fix/revert-9418 branch November 6, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants