[BugFix] Fix Ipv6 Pointer Comparison Bug

[ijrsvt]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes a bug where Pointer addresses are compared, not Pointer values. This results in an issue for secondary services sharing an IPv6 address. findFrontendIPConfigsOfService will return IPv6 addresses as v4, but getIPFamiliesEnabled returns the correct IP version because it looks at the svc.Spec.IPFamilies

NOTE: The tests added fail without the corresponding change in this PR.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixes a bug where services sharing an Azure IPv6 pip would not get reconciled due to conflicting ip configurations in the Load Balancer.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Welcome @ijrsvt!

It looks like this is your first PR to kubernetes-sigs/cloud-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cloud-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ijrsvt
Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @ijrsvt. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[nilo19]

@ijrsvt thanks for your fix. I will file another one containing your fix and e2e tests.

[nilo19]

/ok-to-test

[nilo19]

/test pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz

[nilo19]

/test pull-cloud-provider-azure-e2e-ccm-ipv6-capz

[nilo19]

/test cloud-provider-azure-master-ipv6-capz

[k8s-ci-robot]

@nilo19: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cloud-provider-azure-check

/test pull-cloud-provider-azure-e2e-capz

/test pull-cloud-provider-azure-e2e-ccm-capz

/test pull-cloud-provider-azure-e2e-ccm-dualstack-capz

/test pull-cloud-provider-azure-e2e-ccm-dualstack-vmss-capz

/test pull-cloud-provider-azure-e2e-ccm-ipv6-capz

/test pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz

/test pull-cloud-provider-azure-e2e-ccm-vmss-capz

/test pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz

/test pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz

/test pull-cloud-provider-azure-e2e-ccm-vmss-shared-probe-capz

/test pull-cloud-provider-azure-e2e-ccm-vmssflex-capz

/test pull-cloud-provider-azure-unit

Use /test all to run the following jobs that were automatically triggered:

pull-cloud-provider-azure-check

pull-cloud-provider-azure-e2e-capz

pull-cloud-provider-azure-e2e-ccm-capz

pull-cloud-provider-azure-e2e-ccm-vmss-capz

pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz

pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz

pull-cloud-provider-azure-e2e-ccm-vmss-shared-probe-capz

pull-cloud-provider-azure-e2e-ccm-vmssflex-capz

pull-cloud-provider-azure-unit

In response to this:

/test cloud-provider-azure-master-ipv6-capz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[nilo19]

/retest

[k8s-ci-robot]

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[nilo19]

/ok-to-test

[k8s-ci-robot]

@ijrsvt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz	ac1b07f	link	true	/test pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz
pull-cloud-provider-azure-e2e-ccm-ipv6-capz	ac1b07f	link	true	/test pull-cloud-provider-azure-e2e-ccm-ipv6-capz
pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz	8700c81	link	true	/test pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz
pull-cloud-provider-azure-e2e-ccm-vmss-shared-probe-capz	8700c81	link	true	/test pull-cloud-provider-azure-e2e-ccm-vmss-shared-probe-capz
pull-cloud-provider-azure-e2e-ccm-vmssflex-capz	8700c81	link	true	/test pull-cloud-provider-azure-e2e-ccm-vmssflex-capz
pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz	8700c81	link	true	/test pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz
pull-cloud-provider-azure-e2e-ccm-capz	8700c81	link	true	/test pull-cloud-provider-azure-e2e-ccm-capz
pull-cloud-provider-azure-e2e-ccm-vmss-capz	8700c81	link	true	/test pull-cloud-provider-azure-e2e-ccm-vmss-capz
pull-cloud-provider-azure-e2e-capz	8700c81	link	true	/test pull-cloud-provider-azure-e2e-capz

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[nilo19]

#9596 use this one.