fix: Remove managed pip if switched to another pip in a different res… #8419

nilo19 · 2025-02-24T04:21:35Z

…ource group

What type of PR is this?

/kind bug

What this PR does / why we need it:

We should remove managed pip when the service switches to a different pip in another resource group.

Which issue(s) this PR fixes:

Fixes #8113

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: Remove managed pip if switched to another pip in a different resource group

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

coveralls · 2025-02-24T04:42:06Z

coverage: 74.64% (+0.02%) from 74.618%
when pulling a31b322 on nilo19:fix/pip
into 01e8d0f on kubernetes-sigs:master.

nilo19 · 2025-02-26T03:36:17Z

/retest pull-cloud-provider-azure-e2e-ccm-capz\

k8s-ci-robot · 2025-02-26T03:36:20Z

@nilo19: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test pull-cloud-provider-azure-check

/test pull-cloud-provider-azure-e2e-capz

/test pull-cloud-provider-azure-e2e-ccm-capz

/test pull-cloud-provider-azure-e2e-ccm-dualstack-capz

/test pull-cloud-provider-azure-e2e-ccm-dualstack-vmss-capz

/test pull-cloud-provider-azure-e2e-ccm-ipv6-capz

/test pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz

/test pull-cloud-provider-azure-e2e-ccm-vmss-capz

/test pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz

/test pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz

/test pull-cloud-provider-azure-e2e-ccm-vmss-shared-probe-capz

/test pull-cloud-provider-azure-e2e-ccm-vmssflex-capz

/test pull-cloud-provider-azure-unit

Use /test all to run the following jobs that were automatically triggered:

pull-cloud-provider-azure-check

pull-cloud-provider-azure-e2e-capz

pull-cloud-provider-azure-e2e-ccm-capz

pull-cloud-provider-azure-e2e-ccm-vmss-capz

pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz

pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz

pull-cloud-provider-azure-e2e-ccm-vmss-shared-probe-capz

pull-cloud-provider-azure-e2e-ccm-vmssflex-capz

pull-cloud-provider-azure-unit

In response to this:

/retest pull-cloud-provider-azure-e2e-ccm-capz\

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

nilo19 · 2025-02-26T03:36:28Z

/test pull-cloud-provider-azure-e2e-ccm-capz

nilo19 · 2025-02-26T11:02:48Z

/test pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz

nilo19 · 2025-02-26T11:03:43Z

/retest

feiskyer · 2025-02-27T10:00:13Z

pkg/provider/azure_loadbalancer.go

+			pipID := strings.ToLower((ptr.Deref(pipCopy.ID, "")))
+			rg, err := getPIPRGFromID(pipID)
+			if err != nil {
+				logger.Error(err, "Failed to get resource group from PIP ID", "pip-id", pipID)


return err here?

feiskyer · 2025-02-27T10:01:55Z

pkg/provider/azure_loadbalancer.go

 // reconcilePublicIPs reconciles the PublicIP resources similar to how the LB is reconciled.
 func (az *Cloud) reconcilePublicIPs(ctx context.Context, clusterName string, service *v1.Service, lbName string, wantLb bool) ([]*armnetwork.PublicIPAddress, error) {
+	logger := klog.FromContext(ctx).WithName("reconcilePublicIPs").
+		WithValues("load-balancer", lbName)


how about using the same log format for those keys, e.g. loadBalancer, resourceGroup (in the following lines)?

…ource group

nilo19 · 2025-02-28T07:54:49Z

/retest

feiskyer

/lgtm

k8s-ci-robot · 2025-03-03T02:52:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [feiskyer,nilo19]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nilo19 · 2025-03-03T09:04:42Z

/retest

nilo19 · 2025-03-05T03:31:59Z

/cherrypick release-1.32

nilo19 · 2025-03-05T03:32:05Z

/cherrypick release-1.31

nilo19 · 2025-03-05T03:32:09Z

/cherrypick release-1.30

nilo19 · 2025-03-05T03:32:12Z

/cherrypick release-1.29

k8s-infra-cherrypick-robot · 2025-03-05T03:32:49Z

@nilo19: #8419 failed to apply on top of branch "release-1.31":

Applying: fix: Remove managed pip if switched to another pip in a different resource group
Using index info to reconstruct a base tree...
M	pkg/provider/azure_loadbalancer.go
M	pkg/provider/azure_loadbalancer_test.go
M	pkg/provider/azure_publicip_repo.go
M	pkg/provider/azure_test.go
M	tests/e2e/network/ensureloadbalancer.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/network/ensureloadbalancer.go
Auto-merging pkg/provider/azure_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_test.go
Auto-merging pkg/provider/azure_publicip_repo.go
CONFLICT (content): Merge conflict in pkg/provider/azure_publicip_repo.go
Auto-merging pkg/provider/azure_loadbalancer_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_loadbalancer_test.go
Auto-merging pkg/provider/azure_loadbalancer.go
CONFLICT (content): Merge conflict in pkg/provider/azure_loadbalancer.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix: Remove managed pip if switched to another pip in a different resource group

In response to this:

/cherrypick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-infra-cherrypick-robot · 2025-03-05T03:32:50Z

@nilo19: new pull request created: #8516

In response to this:

/cherrypick release-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-infra-cherrypick-robot · 2025-03-05T03:32:50Z

@nilo19: #8419 failed to apply on top of branch "release-1.30":

Applying: fix: Remove managed pip if switched to another pip in a different resource group
Using index info to reconstruct a base tree...
M	pkg/provider/azure_loadbalancer.go
M	pkg/provider/azure_loadbalancer_test.go
M	pkg/provider/azure_publicip_repo.go
M	pkg/provider/azure_test.go
M	tests/e2e/network/ensureloadbalancer.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/network/ensureloadbalancer.go
Auto-merging pkg/provider/azure_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_test.go
Auto-merging pkg/provider/azure_publicip_repo.go
CONFLICT (content): Merge conflict in pkg/provider/azure_publicip_repo.go
Auto-merging pkg/provider/azure_loadbalancer_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_loadbalancer_test.go
Auto-merging pkg/provider/azure_loadbalancer.go
CONFLICT (content): Merge conflict in pkg/provider/azure_loadbalancer.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix: Remove managed pip if switched to another pip in a different resource group

In response to this:

/cherrypick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-infra-cherrypick-robot · 2025-03-05T03:32:51Z

@nilo19: #8419 failed to apply on top of branch "release-1.29":

Applying: fix: Remove managed pip if switched to another pip in a different resource group
Using index info to reconstruct a base tree...
M	pkg/provider/azure_loadbalancer.go
M	pkg/provider/azure_loadbalancer_test.go
M	pkg/provider/azure_publicip_repo.go
M	pkg/provider/azure_test.go
M	tests/e2e/network/ensureloadbalancer.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/network/ensureloadbalancer.go
Auto-merging pkg/provider/azure_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_test.go
Auto-merging pkg/provider/azure_publicip_repo.go
CONFLICT (content): Merge conflict in pkg/provider/azure_publicip_repo.go
Auto-merging pkg/provider/azure_loadbalancer_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_loadbalancer_test.go
Auto-merging pkg/provider/azure_loadbalancer.go
CONFLICT (content): Merge conflict in pkg/provider/azure_loadbalancer.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix: Remove managed pip if switched to another pip in a different resource group

In response to this:

/cherrypick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Feb 24, 2025

k8s-ci-robot requested review from MartinForReal and andyzhangx February 24, 2025 04:21

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 24, 2025

nilo19 force-pushed the fix/pip branch 4 times, most recently from a31b322 to e2f5b3b Compare February 25, 2025 22:36

MartinForReal force-pushed the fix/pip branch from e2f5b3b to cbca9f8 Compare February 26, 2025 03:44

feiskyer reviewed Feb 27, 2025

View reviewed changes

fix: Remove managed pip if switched to another pip in a different res…

1ecf143

…ource group

nilo19 force-pushed the fix/pip branch from cbca9f8 to 1ecf143 Compare February 27, 2025 22:20

feiskyer approved these changes Mar 3, 2025

View reviewed changes

k8s-ci-robot assigned feiskyer Mar 3, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2025

k8s-ci-robot merged commit c86a3cb into kubernetes-sigs:master Mar 3, 2025
18 checks passed

nilo19 deleted the fix/pip branch March 5, 2025 00:48

k8s-infra-cherrypick-robot mentioned this pull request Mar 5, 2025

[release-1.32] fix: Remove managed pip if switched to another pip in a different res… #8516

Merged

fix: Remove managed pip if switched to another pip in a different res… #8419

fix: Remove managed pip if switched to another pip in a different res… #8419

Uh oh!

Conversation

nilo19 commented Feb 24, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

coveralls commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nilo19 commented Feb 26, 2025

Uh oh!

k8s-ci-robot commented Feb 26, 2025

Uh oh!

nilo19 commented Feb 26, 2025

Uh oh!

nilo19 commented Feb 26, 2025

Uh oh!

nilo19 commented Feb 26, 2025

Uh oh!

feiskyer Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

nilo19 Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

feiskyer Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nilo19 Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

nilo19 commented Feb 28, 2025

Uh oh!

feiskyer left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Mar 3, 2025

Uh oh!

nilo19 commented Mar 3, 2025

Uh oh!

Uh oh!

nilo19 commented Mar 5, 2025

Uh oh!

nilo19 commented Mar 5, 2025

Uh oh!

nilo19 commented Mar 5, 2025

Uh oh!

nilo19 commented Mar 5, 2025

Uh oh!

k8s-infra-cherrypick-robot commented Mar 5, 2025

Uh oh!

k8s-infra-cherrypick-robot commented Mar 5, 2025

Uh oh!

k8s-infra-cherrypick-robot commented Mar 5, 2025

Uh oh!

k8s-infra-cherrypick-robot commented Mar 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coveralls commented Feb 24, 2025 •

edited

Loading

feiskyer Feb 27, 2025 •

edited

Loading