-
Notifications
You must be signed in to change notification settings - Fork 87
Add support for cleaning ECR images in aws-janitor #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4cb0d19 to
9d68bf2
Compare
|
/lgtm cc: @dims |
|
@ConnorJC3 i understand and agree that false by default is helpful. but |
9d68bf2 to
21ffe26
Compare
21ffe26 to
e817e7b
Compare
|
@dims good idea, newest rev switches the flag from a binary true/false to a list of repos to clean |
Signed-off-by: Connor Catlett <[email protected]>
e817e7b to
860380e
Compare
|
/lgtm |
|
/assign stevekuznetsov Assigning @stevekuznetsov as |
Summary
Adds a new janitor feature to clean ECR container images from repos (does not delete the repos themselves). There is a limit of 10k images per repository, and every few months our CI hits this limit and we have to manually clean out the repo.
This janitor is disabled by default and must be enabled by CLI flag (1) to avoid breaking anyone's existing workflow and (2) because it is not possible to tag ECR repos, so it is not possible to skip repos with this cleaner, it will clean all ECR repos.
Also had to bump some AWS SDK dependencies to get this to work.
Testing
Dry run test:
Real delete test: