use one instance of acm cert discovery in gateway builder #4493
+23
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While testing the Gateway API implementation at scale, I noticed a tiny memory leak (90Mi -> 110Mi) over the course of a weekend. I believe the issue is that we're recreating the cert discovery component for every build listener call in the Gateway API. This object is meant to be a singleton, as it creates caches on every instantiation. As a bonus, this seems to reduce the latency quite considerably for reconciliation times:
The screenshot shows reconcile runs that finish in under 10 seconds [I have 200 gateways provisioned]. The first line is with using 1 cert discovery instance per listener builder, the following lines are using the singleton.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯