Skip to content

Auto discovery default certificate and certificate list #4490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abeowlu wants to merge 5 commits into
base: main
Choose a base branch
from
+1 −1
Open

Auto discovery default certificate and certificate list #4490

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e09e62
push ff
abeowlu Dec 8, 2025
b36e823
auto-discovery default cert use
abeowlu Dec 8, 2025
435ded0
auto-discovery default cert use
abeowlu Dec 9, 2025
79b0c32
missing test
abeowlu Dec 9, 2025
0320065
rebase test
abeowlu Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/deploy/elbv2/listener_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ func buildSDKCertificates(modelCerts []elbv2model.Certificate) ([]elbv2types.Cer
var defaultSDKCerts []elbv2types.Certificate
var extraSDKCerts []elbv2types.Certificate
defaultSDKCerts = append(defaultSDKCerts, buildSDKCertificate(modelCerts[0]))
for _, cert := range modelCerts[1:] {
for _, cert := range modelCerts {
extraSDKCerts = append(extraSDKCerts, buildSDKCertificate(cert))
}
return defaultSDKCerts, extraSDKCerts
Expand Down